Update for UnrealEngine's wrong file path #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuYicong
approved these changes
Dec 7, 2024
Ryu-ga
force-pushed
the
main
branch
3 times, most recently
from
ab77730 to
057e18f
Compare
Really, I'm a trash generator.. |
|
Sorry, I can't test it, |
Yes I tested it in both PlayTools and pure C program. |
TheMoonThatRises
requested changes
Dec 20, 2024
|
|
||
| static char const* ue_fix_filename(char const* filename) { | ||
| static char UE_PATTERN[1024] = "//Users/"; | ||
| getlogin_r(UE_PATTERN + 8, sizeof(UE_PATTERN) - 8); |
There was a problem hiding this comment.
What does this function do in the code (seems unused)?
| static char UE_PATTERN[1024] = "//Users/"; | ||
| getlogin_r(UE_PATTERN + 8, sizeof(UE_PATTERN) - 8); | ||
|
|
||
| char const* p = filename; |
There was a problem hiding this comment.
Can you rename this variable so it is more descriptive of its purpose?
| if (is_ue4) { | ||
| [PlayKeychain debugLogger: [NSString stringWithFormat:@"Is it UE4? : %@", @(is_ue4)]]; | ||
|
|
||
| if (ue_status == 0) { |
There was a problem hiding this comment.
Will ue_status never equal 0 on initialization?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file name ue4commandline.txt has been changed to uecommandline.txt in UE5.
Some applications mistakenly use both Library\Users and Documents\Users paths multiple times within a single path, more often than I expected.
To address this, I ensure that PlayTools retrieves the string from the last needle of the incorrect path.
Issue: PlayCover/PlayCover#1755