Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds scikit-learn as a dependency and requires Python 3.10.
Scikit-learn
Scikit-learn is used by the file
resources/model.joblib
, so I got this error when I first ran the project after runningpipenv install
and thenpipenv shell
:scikit-learn include error
I tried installing the latest scikit-learn, but then got a warning about the
RandomForestClassifier
in thejoblib
file using version 1.0.2 and then psplot crashed again:scikit-learn version error
I set the Pipfile version to 1.0.2, and it works. This old scikit-learn is using a deprecated feature though so it generates warnings. At some point I can update the model file to use a recent version, but I'm not yet sure how to reproduce the classifier.
Use Python 3.10, not 3.8
Since 3.8 is specified in the Pipfile,
pipenv install
will pause for a while looking for a 3.8 install on the disk. If it is installed or the user tries to install it, running the project does not work because it uses dictionary merging with|
, introduced in 3.9. Therefore just setting version to 3.10 matching the other instructions.Pipfile.lock
Probably worth committing the
Pipfile.lock
file, for more deterministic installation, also should make it a bit quicker. It keeps track of the package versions, so users know they are using the same PSplot as the developers. Recommended by the pipenv docs:I can add that change here if others agree. I know the desire is to package PSplot so users don't have to use pipenv at all (#13), but this should help move toward that.