-
Notifications
You must be signed in to change notification settings - Fork 12
Tutorial example for cold plasma dielectric tensor elements #16
base: main
Are you sure you want to change the base?
Conversation
jhillairet
commented
Jun 7, 2019
•
edited
Loading
edited
- Added a first draft of how to deduce cold plasma dielectric parameters using PlasmaPy
- Corrected 2 URLs in the .md files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jhillairet, thanks a ton for doing this! To be honest I wasn't even aware of this sub-repository until yesterday. Sorry for the delayed response.
We'll have to think what the best place to keep these would be - we've mostly been using sphinx-gallery
to render notebooks out of plain python files in the source repo with parsable comments (easier to version-control those). But obviously that's a specialized format that's pretty annoying to work with and I'm sure people would prefer to work with straight ipynb when contributing. I'm not yet sure what the best way of dealing with this is - I'll look around and figure something out.
Still, that's the technical side and on me to deal with. With regards to the tutorial, it's pretty awesome, I just have a few suggestions on how to make it even better :) Once again, thanks for doing this!
"cell_type": "markdown", | ||
"metadata": {}, | ||
"source": [ | ||
"Before plotting them against the frequency, let's filter positive and negative values, in order to display propagative and evanscent cases " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo (already fixed):
"Before plotting them against the frequency, let's filter positive and negative values, in order to display propagative and evanscent cases " | |
"Before plotting them against the frequency, let's filter positive and negative values, in order to display propagative and evanescent cases " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, as a relative layman, I would love to see a sentence describing what those cases actually are - am I right in thinking that something like this would fit?
These are solutions that respectively propagate through the plasma or are quickly attenuated (exponential damping).
as in e^(i omega t) versus e^(omega t).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, that's just an update of the example I've made in the gallery few time ago.
Concerning the sentence, in fact that's not so direct and I should modify the text. To know if the wave is evanescent or propagative, one should calculate the wave number using the dispersion relation. That's the next step to improve the example.
"cell_type": "markdown", | ||
"metadata": {}, | ||
"source": [ | ||
"## Cold Plasma tensor elements in the rotating basis" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this spot could also use a really brief description. Am I right saying that those would be left-handed and right-handed circularly polarized waves?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes indeed.
I'll push a few of those technical changes in a minute... |
A question (I didn't follow all the discussions on the mailing list or github) : is there a better way to deal with units than importing astropy.units ? |
Nope, I don't think there is one - you either make the units explicit or get warnings on assuming default ones (at least I think that's how we currently want to have it work). |