Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize ad-hoc plural synoynm type #722

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Standardize ad-hoc plural synoynm type #722

merged 2 commits into from
Jan 24, 2024

Conversation

cthoyt
Copy link
Contributor

@cthoyt cthoyt commented Oct 27, 2023

@cthoyt cthoyt marked this pull request as ready for review October 27, 2023 08:51
@cthoyt cthoyt mentioned this pull request Oct 27, 2023
Open
@cthoyt
Copy link
Contributor Author

cthoyt commented Nov 7, 2023

@jaiswalp @elserj any chance you could take a look at this?

elserj
elserj reviewed Nov 7, 2023
View reviewed changes
Copy link
Member

@elserj elserj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I loaded this version up on dev and didn't see any issues, but I'm not sure how they would show up in AmiGO anyway. @cmungall would it effect that at all or is this just a change to how Protege etc.. will view the files?

Also adding @cooperl09 for input.

@cooperl09 cooperl09 merged commit 908e260 into Planteome:master Jan 24, 2024
@cthoyt cthoyt deleted the patch-1 branch January 24, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elserj elserj elserj left review comments

@cmungall cmungall cmungall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cthoyt @cmungall @elserj @cooperl09