-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flask test #13
Open
zvek6
wants to merge
11
commits into
main
Choose a base branch
from
flask_test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Flask test #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plus minimized the text for languages
*cutlines + page numbering *edited few files *runs from main only!
Open
zvek6
commented
Sep 12, 2023
|
||
import src.pdfbooklet_new as pdfbooklet_new | ||
import pdfbooklet_new as pdfbooklet_new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems like this fails the CI, maybe move you father folder in flask one folder backwords
zvek6
commented
Sep 12, 2023
src/webUI.py
Outdated
Comment on lines
78
to
79
files = [file for file in list_dir if original_name_part in file and original_name!=file] | ||
return files[0] # should be only one element... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
files = [file for file in list_dir if original_name_part in file and original_name!=file] | |
return files[0] # should be only one element... | |
files = [file for file in list_dir if original_name_part in file and original_name!=file] | |
assert len(files) == 1, f"Only one file should be given! files = {files}" | |
return files[0] |
better version
might solve bug that on others PC couldn't find the correct path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.