Community #61
Open
Community #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
добавил card
* master: (49 commits) refactor About fix App.js add Header in HomePage refactor Header Changed necessary props for component Added lint rule to Makefile Created new component move about images into asset corrects according to the reviewer comments remove buggy deps, remove doubled icons fix BEM naming update lock file add footer remove buggy deps, remove doubled icons fix lint fix BEM naming update lock file add footer add created UI components Update README ... # Conflicts: # app/components/Community/CommunityList.js
* master: refactor layout wrapping delete 'run' from npm install fix main page layout fix Layout bug fix style .InnerPageContentContainer-Inner add on pr to tests workflows delete Header and Footer from Participants add global layout, remove header & footer from homepage add Header, Footer to Participants add author to activity, move routes to config, update header change header footer theme on main fix BEM naming use explicit Fragement add InnerPageContentContainer refactoring Participants fixed white-space delete store from package-lock.json delete store from package.json create header for Participants create route /participants, create component Participants # Conflicts: # app/App.js # app/components/Community/CommunityList.js
strdmitriy
reviewed
Jan 30, 2020
|
|
||
| .header-wrapper::after { | ||
| position: absolute; | ||
| bottom: -20px; |
|
|
||
| padding: 26px; | ||
| width: 380px; | ||
| /*height: 156px;*/ |
| const splitList = arr => { | ||
| if (arr.length === 1) { | ||
| return [[arr[0]], []] | ||
| } |
There was a problem hiding this comment.
чет сложно, проще нельзя сделать ?
There was a problem hiding this comment.
это костыль, падало при условии 1 записи в выдаче фильтра.
| const { user, community, dispatch } = useStoreon('community', 'user') | ||
| const [filtered, setFiltered] = useState(community.list) | ||
| // console.log(filtered, community.list) |
There was a problem hiding this comment.
если код не нужен, то удалить console.log() везде
| } | ||
|
|
||
| setMore = more => { | ||
| // const style = more ? descStyle: { } |
There was a problem hiding this comment.
что за комментарии по всем файлам раскиданы?
| <Icon | ||
| className="title__icon" | ||
| onClick={onSort} | ||
| type="sort-ascending" |
There was a problem hiding this comment.
зачем 2 Icon, у тебя же только тип меняется и соответственно и Icon. Меняй тип по условию
There was a problem hiding this comment.
Нужно делать сортировку по имени, кол-ву людей, послед. активностям?
может нужно сделать popup с вариантами сортировки?
* master: (45 commits) add styles to map Update build.yml move apiKey to dotenv add map add partners Refactor activity list filter Fix paths for activity Fix activity page after refactor Refactor activity page fix CSS PastEvents add real images add autoplay for Carousel add communities add styles for PastEvents Update css activity item filter block refactor ActivityList fix merged files merge master add program section add link to community ... # Conflicts: # app/components/Community/CommunityList.js # package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Посмотрите как работает фильтр и подробнее.