[Algorithms] Add clustering algorithms #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my initial review I couldn't understand how the cluster membership was being cleared, so I wrote this test. Perhaps its useful to retain, despite the fact that your implementation works fine and the test passes with no modification to the algo.
daniellovell
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
In my initial review I couldn't understand how the cluster membership was being cleared, so I wrote a new KMeansClustererTest.
Perhaps its useful to retain, despite the fact that your implementation works fine and the test passes with no modification to the algo.
Assets/Tests/EditMode/ClusterTest.cs
Outdated
|
|
||
| [Test] | ||
| public void TestCentroid() { | ||
| const float radius = 3; |
There was a problem hiding this comment.
Unused variable prompting linter warning
Assets/Tests/EditMode/ClusterTest.cs
Outdated
|
|
||
| [Test] | ||
| public void TestRecenter() { | ||
| const float radius = 3; |
There was a problem hiding this comment.
Unused variable prompting linter warning
Sorry about that
|
I recommend updating the branch from master as part of the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some clustering algorithms and helper classes, e.g., the
Clusterclass and theIClustererinterface. Constrained clustering algorithms are also included and constrain the size and radius of each cluster.