Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order Client Plugin Update #252

Merged
merged 7 commits into from
Sep 12, 2023
Merged

Order Client Plugin Update #252

merged 7 commits into from
Sep 12, 2023

Conversation

dalyathan
Copy link
Member

@dalyathan dalyathan commented Sep 5, 2023

Description

  • registerCustomerAccount, requestPasswordReset and resetPassword checkout operations have been implemented.
  • Added contribution/development guide about generating types
  • Added $currentUser store
  • Always return ActiveOrder<A> or ActiveOrder<A> | undefined for consistency. Don't use ActiveOrderFieldsFragment

Breaking changes

  • Not exporting all generated types anymore
  • Don't return undefined for most mutations
  • Removed getters/setters: Consumers should use useStore(client.$activeOrder)

Checklist

📌 Always:

  • I have set a clear title
  • My PR is small and contains only a single feature. (Split into multiple PR's if needed)
  • I have reviewed my own PR, fixed all typo's and removed unused/commented code

⚡ Most of the time:

  • I have added or updated test cases for important functionality
  • I have updated the README if needed

📦 For publishable packages:

  • Have you correctly increased the version number in package.json to the next patch/minor/major?
  • Have you added your changes to the changelog?

Copy link
Member

@martijnvdbrug martijnvdbrug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some cahnges, but other than that: great!

@martijnvdbrug martijnvdbrug merged commit cbce909 into main Sep 12, 2023
25 checks passed
@martijnvdbrug martijnvdbrug deleted the feat/order-client-update branch September 12, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants