Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storing failed and successful payments for Stripe Plugin #241

Merged
merged 14 commits into from
Aug 16, 2023

Conversation

dalyathan
Copy link
Member

@dalyathan dalyathan commented Aug 9, 2023

Description

This changes allows the plugin to store successful and failed payments. Also the subscription schedules lists will be shown in a vdr-data-table-2. Should close #235.

Breaking changes

The query endpoint stripeSubscriptionSchedules now returns a PaginatedList.

Screenshots

Screenshot from 2023-08-09 13-04-05
Screenshot from 2023-08-09 13-04-12

Checklist

📌 Always:

  • I have set a clear title
  • My PR is small and contains only a single feature. (Split into multiple PR's if needed)
  • I have reviewed my own PR, fixed all typo's and removed unused/commented code

⚡ Most of the time:

  • I have added or updated test cases for important functionality
  • I have updated the README if needed

📦 For publishable packages:

Copy link
Member

@martijnvdbrug martijnvdbrug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dalyathan Great work!
I've made some small changes after testing with my live stripe-account. I've pushed them to this branch, so don't forget to pull first!

A few change requests though:

  1. Can you render charge in the Stripe Payments table as currency? So 90.00 instead of 9000
    image

  2. Can you add an e2e test for an incoming invoice.payment_succeeded? The type of the request body can be found in types/stripe-invoice.ts

  3. I've added eventType to the entity, can you also render that in the datatable in the admin? EventType will be any of invoice.payment_succeeded, invoice.payment_failed, invoice.action_required

Let me know if you have any questions

@martijnvdbrug martijnvdbrug changed the title WIP: Storing failed and successful payments for Stripe Plugin Storing failed and successful payments for Stripe Plugin Aug 16, 2023
Copy link
Member

@martijnvdbrug martijnvdbrug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, thanks!

@martijnvdbrug martijnvdbrug merged commit 5e6d335 into main Aug 16, 2023
20 of 25 checks passed
@martijnvdbrug martijnvdbrug deleted the feat/store-payment-status branch August 16, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stripe Subscription: Store successful and failed payments and show in Widget
2 participants