-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storing failed and successful payments for Stripe Plugin #241
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dalyathan Great work!
I've made some small changes after testing with my live stripe-account. I've pushed them to this branch, so don't forget to pull first!
A few change requests though:
-
Can you render
charge
in the Stripe Payments table as currency? So90.00
instead of 9000
-
Can you add an e2e test for an incoming
invoice.payment_succeeded
? The type of the request body can be found intypes/stripe-invoice.ts
-
I've added
eventType
to the entity, can you also render that in the datatable in the admin? EventType will be any ofinvoice.payment_succeeded
,invoice.payment_failed
,invoice.action_required
Let me know if you have any questions
…hook payment success
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, thanks!
Description
This changes allows the plugin to store successful and failed payments. Also the subscription schedules lists will be shown in a
vdr-data-table-2
. Should close #235.Breaking changes
The query endpoint
stripeSubscriptionSchedules
now returns aPaginatedList
.Screenshots
Checklist
📌 Always:
⚡ Most of the time:
📦 For publishable packages:
package.json
to the next patch/minor/major?