Merge pull request #270 from Pinelab-studio/fix/picqer-failing-webhook

Fix/picqer failing webhook

packages/vendure-plugin-picqer/CHANGELOG.md

@@ -1,3 +1,7 @@
+# 1.0.11
+
+- Don't throw insufficient stock errors on incoming webhooks, because it will eventually disable the entire webhook in Picqer
+
 # 1.0.10
 
 - Send streetline1 + streetline2 as address in Picqer

packages/vendure-plugin-picqer/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pinelab/vendure-plugin-picqer",
-  "version": "1.0.10",
+  "version": "1.0.11",
   "description": "Vendure plugin syncing to orders and stock with Picqer",
   "author": "Martijn van de Brug <[email protected]>",
   "homepage": "https://pinelab-plugins.com/",

packages/vendure-plugin-picqer/src/api/picqer.controller.ts

@@ -22,11 +22,27 @@ export class PicqerController {
     );
     // Middleware isn't loaded when using the test server from @vendure/testing, so we use the normal body
     const rawBody = (req as any).rawBody || JSON.stringify(body);
-    await this.picqerService.handleHook({
-      body,
-      channelToken,
-      rawBody,
-      signature,
-    });
+    try {
+      await this.picqerService.handleHook({
+        body,
+        channelToken,
+        rawBody,
+        signature,
+      });
+    } catch (e: any) {
+      Logger.error(
+        `Error handling incoming hook '${body.event}': ${e.message}`,
+        loggerCtx
+      );
+
+      // FIXME: For now, don't throw insufficient stock error, to prevent webhook disabling
+      if (
+        e.message ===
+        'INSUFFICIENT_STOCK_ON_HAND_ERROR: INSUFFICIENT_STOCK_ON_HAND_ERROR'
+      ) {
+        return;
+      }
+      throw e;
+    }
   }
 }