Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid spurious inequality optimization hits #11

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

avoid spurious inequality optimization hits #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/issues/GAS/unsignedComparison.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ const issue: RegexIssue = {
regexOrAST: 'Regex',
type: IssueTypes.GAS,
title: 'Use != 0 instead of > 0 for unsigned integer comparison',
regex: /([a-z,A-Z,0-9]*>.?0|0.?<.?[a-z,A-Z,0-9]*)/g,
regex: /(?!pragma\s*solidity)[a-z,A-Z,0-9]*>.?0|0.?<.?[a-z,A-Z,0-9]*/g,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-01-18 at 3 16 27 PM

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it currently works

};

export default issue;