Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move top-level .cpp files into their respective folders #1249

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Conversation

uweseimet
Copy link
Contributor

No description provided.

@uweseimet
Copy link
Contributor Author

@dialtr I still cannot add you to the reviewers list. This is probably because you are not in the list of collaborators.

@akuker @rdmark Can you please add Tom to this list? I addition, I would appreciate the change of the SonarCloud setting I asked for in #1232 to be applied:

Please disable this warning in SonarCloud:

Reduce verbosity with "using enum"

We cannot address this issue because the bullseye compiler does not support "using enum", and whether/where to use "using enum" is optional anyway.

@sonarcloud
Copy link

sonarcloud bot commented Oct 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@uweseimet uweseimet marked this pull request as ready for review October 16, 2023 08:27
@akuker
Copy link
Member

akuker commented Oct 16, 2023

Reduce verbosity with "using enum"

Is this the right setting? I don't see anything with that exact wording:
https://sonarcloud.io/organizations/piscsi/rules?open=cpp%3AS6177&rule_key=cpp%3AS6177

I've also added you as an owner for the SonarCloud project, so you should be able to make additional changes if needed.

@akuker
Copy link
Member

akuker commented Oct 16, 2023

Invitation sent to @dialtr to become a collaborator. Let me know if you have any issues!

@dialtr
Copy link
Collaborator

dialtr commented Oct 16, 2023 via email

@uweseimet
Copy link
Contributor Author

@akuker I think this is the right setting. Sometimes I am also struggling with the exact meaning/wording of the settings. Let's just give it a try, we will know soon whether it is correct.

@uweseimet uweseimet merged commit aa927cb into develop Oct 16, 2023
15 of 16 checks passed
@uweseimet uweseimet deleted the issue_1219 branch October 16, 2023 16:27
uweseimet added a commit that referenced this pull request Oct 16, 2023
* Update Makefile, move top-level .cpp files

* Move top-level .cpp files into their respective folders
uweseimet added a commit that referenced this pull request Oct 16, 2023
* Update Makefile, move top-level .cpp files

* Move top-level .cpp files into their respective folders
uweseimet added a commit that referenced this pull request Oct 16, 2023
* Update Makefile, move top-level .cpp files

* Move top-level .cpp files into their respective folders
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consistent source file structure: Move top-level .cpp files into their respective folders
3 participants