Optimize using find_if_not()

PiSCSI · Sep 8, 2023 · 567467e · 567467e
1 parent a1fbca9
commit 567467e
Showing 1 changed file with 2 additions and 7 deletions.
diff --git a/cpp/piscsi/piscsi_executor.cpp b/cpp/piscsi/piscsi_executor.cpp
@@ -625,13 +625,8 @@ string PiscsiExecutor::ValidateLunSetup(const PbCommand& command) const
 	}
 
 	// LUN 0 must exist for all devices
-	for (const auto& [id, lun]: luns) {
-		if (!(lun & 0x01)) {
-			return "LUN 0 is missing for device ID " + to_string(id);
-		}
-	}
-
-	return "";
+	const auto& it = ranges::find_if_not(luns, [] (const auto& l) { return l.second & 0x01; } );
+	return it == luns.end() ? "" : "LUN 0 is missing for device ID " + to_string((*it).first);
 }
 
 bool PiscsiExecutor::VerifyExistingIdAndLun(const CommandContext& context, int id, int lun) const