Don't ask for password on sudo for OPi5 images #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The photonvision dev tooling expects the 'pi' user to not ask for password on sudo when running `./gradlew deploy -PArchOverride=linuxarm64`, since this is the default on RPI OS. We should do the same here so that gradle behaves on Orange Pi 5 devices as well.
crschardt
reviewed
Jul 21, 2024
| @@ -8,6 +8,9 @@ else | |||
| usermod -a -G sudo pi | |||
| mkdir /home/pi | |||
| chown -R pi /home/pi | |||
|
|
|||
| echo 'pi ALL=(ALL) NOPASSWD: ALL' | tee -a /etc/sudoers.d/010_pi-nopasswd >/dev/null | |||
There was a problem hiding this comment.
Is there a benefit to piping to tee -a over using >> to append to this file?
There was a problem hiding this comment.
Either way is fine. I went with this approach here because it was what I validated before rebuilding the image (swapping tee for sudo tee), and the rest of the script didn't set a strong precedent one way or the other.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The photonvision dev tooling expects the 'pi' user to not ask for password on sudo when running
./gradlew deploy -PArchOverride=linuxarm64, since this is the default on RPI OS.We should do the same here so that gradle behaves on Orange Pi 5 devices as well.