-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Relies on #263] Style update #264
Open
aljelly
wants to merge
15
commits into
Philip-Scott:page-list-upgrade
Choose a base branch
from
aljelly:style-update
base: page-list-upgrade
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
0b18f99
Failed attempt to add css file
1f13008
Show date/time on note, sort by modified, format time based on system…
187f596
Remove whitespace
aa195d7
Merge branch 'preview-date' into style-update
0900b83
Fix addition of css file, modify app styling, change editor font size
cd1fd53
Remove unnecessary use_markup on date label
9e92f2c
Merge branch 'master' into preview-date
7e9b7da
Merge branch 'master' into style-update
0ceffaa
PageList: Removed commented code, restored sorting to original state
f1144c5
PageItem: Change labels to be more descriptive, change date formattin…
e58e5a3
Remove ClockSettings, read clock format with GLib.Settings instead (n…
33d07e5
Forgot to change page.modification_date back to page.id
7197ed1
Merge branch 'preview-date' into style-update
fc27fba
Order the label setting alphabetically, change label margins, set hor…
21029fd
Remove commented code from stylesheet.css
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,37 +1,69 @@ | ||
# Used for GResource. | ||
# | ||
# resource_dir: Directory where the .gresource.xml is located. | ||
# resource_file: Filename of the .gresource.xml file (just the | ||
# filename, not the complete path). | ||
# output_dir: Directory where the C output file is written. | ||
# output_file: This variable will be set with the complete path of the | ||
# output C file. | ||
# Copyright (C) 2013 Venom authors and contributors | ||
# | ||
# This file is part of Venom. | ||
# | ||
# Venom is free software: you can redistribute it and/or modify | ||
# it under the terms of the GNU General Public License as published by | ||
# the Free Software Foundation, either version 3 of the License, or | ||
# (at your option) any later version. | ||
# | ||
# Venom is distributed in the hope that it will be useful, | ||
# but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
# GNU General Public License for more details. | ||
# | ||
# You should have received a copy of the GNU General Public License | ||
# along with Venom. If not, see <http://www.gnu.org/licenses/>. | ||
# | ||
|
||
FIND_PROGRAM(GLIB_COMPILE_RESOURCES_EXECUTABLE NAMES glib-compile-resources) | ||
MARK_AS_ADVANCED(GLIB_COMPILE_RESOURCES_EXECUTABLE) | ||
|
||
INCLUDE(CMakeParseArguments) | ||
|
||
function (gresource resource_dir resource_file output_dir output_file) | ||
# Get the output file path | ||
get_filename_component (resource_name ${resource_file} NAME_WE) | ||
set (output "${output_dir}/${resource_name}-resources.c") | ||
set (${output_file} ${output} PARENT_SCOPE) | ||
FUNCTION(GLIB_COMPILE_RESOURCES output) | ||
CMAKE_PARSE_ARGUMENTS(ARGS "" "" "SOURCE" ${ARGN}) | ||
SET(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}) | ||
SET(out_files "") | ||
|
||
# Get the dependencies of the gresource | ||
execute_process ( | ||
OUTPUT_VARIABLE _files | ||
WORKING_DIRECTORY ${resource_dir} | ||
COMMAND ${gresources_executable} --generate-dependencies ${resource_file} | ||
) | ||
FOREACH(src ${ARGS_SOURCE} ${ARGS_UNPARSED_ARGUMENTS}) | ||
SET(in_file "${CMAKE_CURRENT_SOURCE_DIR}/${src}") | ||
GET_FILENAME_COMPONENT(WORKING_DIR ${in_file} PATH) | ||
STRING(REPLACE ".xml" ".c" src ${src}) | ||
SET(out_file "${DIRECTORY}/${src}") | ||
GET_FILENAME_COMPONENT(OUPUT_DIR ${out_file} PATH) | ||
FILE(MAKE_DIRECTORY ${OUPUT_DIR}) | ||
LIST(APPEND out_files "${DIRECTORY}/${src}") | ||
|
||
string (REPLACE "\n" ";" files ${_files}) | ||
#FIXME implicit depends currently not working | ||
EXECUTE_PROCESS( | ||
COMMAND | ||
${GLIB_COMPILE_RESOURCES_EXECUTABLE} | ||
"--generate-dependencies" | ||
${in_file} | ||
WORKING_DIRECTORY ${WORKING_DIR} | ||
OUTPUT_VARIABLE in_file_dep | ||
) | ||
STRING(REGEX REPLACE "(\r?\n)" ";" in_file_dep "${in_file_dep}") | ||
SET(in_file_dep_path "") | ||
FOREACH(dep ${in_file_dep}) | ||
LIST(APPEND in_file_dep_path "${WORKING_DIR}/${dep}") | ||
ENDFOREACH(dep ${in_file_dep}) | ||
ADD_CUSTOM_COMMAND( | ||
OUTPUT ${out_file} | ||
WORKING_DIRECTORY ${WORKING_DIR} | ||
COMMAND | ||
${GLIB_COMPILE_RESOURCES_EXECUTABLE} | ||
ARGS | ||
"--generate-source" | ||
"--target=${out_file}" | ||
${in_file} | ||
DEPENDS | ||
${in_file};${in_file_dep_path} | ||
) | ||
ENDFOREACH(src ${ARGS_SOURCES} ${ARGS_UNPARSED_ARGUMENTS}) | ||
SET(${output} ${out_files} PARENT_SCOPE) | ||
ENDFUNCTION(GLIB_COMPILE_RESOURCES) | ||
|
||
set (depends "") | ||
foreach (cur_file ${files}) | ||
list (APPEND depends "${resource_dir}/${cur_file}") | ||
endforeach () | ||
|
||
# Command to compile the resources | ||
add_custom_command ( | ||
OUTPUT ${output} | ||
DEPENDS "${resource_dir}/${resource_file}" ${depends} | ||
WORKING_DIRECTORY ${resource_dir} | ||
COMMAND ${gresources_executable} --generate-source --target=${output} ${resource_file} | ||
) | ||
endfunction () |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
<?xml version="1.0" encoding="UTF-8"?> | ||
<gresources> | ||
<gresource prefix="/com/github/philip-scott/notes-up"> | ||
<file alias="stylesheet.css" compressed="false" preprocess="">stylesheet.css</file> | ||
</gresource> | ||
</gresources> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
.title-label { | ||
font-size: 1.2em; | ||
font-weight: 700; | ||
} | ||
|
||
.preview-label { | ||
opacity:1; | ||
} | ||
|
||
.date-time-label { | ||
opacity:0.6; | ||
font-size:0.9em; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the change to 10?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought it was more in line with how fonts on the system are sized, I can change it back if you don't like it/don't think it's good.