You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented bottom toolbar with 'Home', 'Compare', and 'Settings' options.
Removed 'Compare' from the top toolbar on Home screen.
Relocated 'Import' to the top toolbar on Home screen.
Shifted 'About' and 'Intro' to the bottom of Settings.
Revised information view layout: split prefixes and data into two rows with indentation for data.
Updated application dependencies (#7).
Renamed the application to 'CheckList'.
Main bottom toolbar for navigation should be on the compare and settings page, right now it is only on the home page.
Update the compare screen by embedding the contains/matches radio group and remove the dialog
Bug: when pressing enter on the main page while focused on the edit text, the UI shifts putting the bottom toolbar above the soft keyboard, the bottom toolbar should remain under the soft keyboard.
…ile focused on the edit text, the UI shifts putting the bottom toolbar above the soft keyboard, the bottom toolbar should remain under the soft keyboard.
Code needs refactoring, duplication of compare fragment/activity along with their resources
Increase top margin of compare screen radio group
Make compare screen edit texts single line
Refactor "B_A_N" to something meaningful
Introduce view models or data helper to separate backend/frontend (create a data helper layer, a class that handles all the backend code which the frontend can reference. Optimally all queries should be prepared statements)
Encapsulate file export, ring notifications and refactor the home fragment
Compare fragment is broken - it only works in matches mode and never switches to contains mode
Initialize the radio group to select matches mode by default, add a preference that saves the user's latest choice
Add compare fragment UI elements that will individually clear the edit texts
right now you can't change compare mode selection when an edit text is selected
last chosen mode is not persisted (use shared preferences or data store)
there is a random "clear" button in the top left that doesn't seem to be functional
the home screen export button is not consistent with other button colors
in FileExport, you don't need the context parameter, use the activity as a context
in RingUtility, use context to get resources, and don't pass the resources as a parameter, same with packageName
in RingUtility you have highly coupled code, write an interface that the activity implements that the util class uses to pass context back to the activity rather than calling UI code directly in the class.
Latest commits seem to break import. When I try importing a file, it imports but doesn't display any data. I checked and the data is in the database, but is not being displayed.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented bottom toolbar with 'Home', 'Compare', and 'Settings' options.
Removed 'Compare' from the top toolbar on Home screen.
Relocated 'Import' to the top toolbar on Home screen.
Shifted 'About' and 'Intro' to the bottom of Settings.
Revised information view layout: split prefixes and data into two rows with indentation for data.
Updated application dependencies (#7).
Renamed the application to 'CheckList'.