Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 #19

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

V2 #19

wants to merge 21 commits into from

Conversation

trife
Copy link
Member

@trife trife commented Feb 6, 2024

Implemented bottom toolbar with 'Home', 'Compare', and 'Settings' options.
Removed 'Compare' from the top toolbar on Home screen.
Relocated 'Import' to the top toolbar on Home screen.
Shifted 'About' and 'Intro' to the bottom of Settings.
Revised information view layout: split prefixes and data into two rows with indentation for data.
Updated application dependencies (#7).
Renamed the application to 'CheckList'.

@chaneylc
Copy link
Member

chaneylc commented Feb 7, 2024

  1. Main bottom toolbar for navigation should be on the compare and settings page, right now it is only on the home page.
  2. Update the compare screen by embedding the contains/matches radio group and remove the dialog
  3. Bug: when pressing enter on the main page while focused on the edit text, the UI shifts putting the bottom toolbar above the soft keyboard, the bottom toolbar should remain under the soft keyboard.

SidMalladi and others added 4 commits February 12, 2024 15:05
… element in which user knows which tab hes in since its highlighted
…ile focused on the edit text, the UI shifts putting the bottom toolbar above the soft keyboard, the bottom toolbar should remain under the soft keyboard.
@chaneylc
Copy link
Member

Rotating the screen makes the current bottom nav bar indicator disappear.

@chaneylc
Copy link
Member

The compare screen update still has the dialog, and the embedded radio group is hard to see.

  1. Remove the dialog choice
  2. embed the radio group in its own demarcated area

@chaneylc
Copy link
Member

The bottom nav bar still displays above the soft keyboard.

@chaneylc
Copy link
Member

chaneylc commented Feb 21, 2024

  • Code needs refactoring, duplication of compare fragment/activity along with their resources
  • Increase top margin of compare screen radio group
  • Make compare screen edit texts single line
  • Refactor "B_A_N" to something meaningful
  • Introduce view models or data helper to separate backend/frontend (create a data helper layer, a class that handles all the backend code which the frontend can reference. Optimally all queries should be prepared statements)
  • Encapsulate file export, ring notifications and refactor the home fragment
  • Compare fragment is broken - it only works in matches mode and never switches to contains mode
  • Initialize the radio group to select matches mode by default, add a preference that saves the user's latest choice
  • Add compare fragment UI elements that will individually clear the edit texts

@chaneylc
Copy link
Member

chaneylc commented Mar 1, 2024

  • right now you can't change compare mode selection when an edit text is selected
  • last chosen mode is not persisted (use shared preferences or data store)
  • there is a random "clear" button in the top left that doesn't seem to be functional
  • the home screen export button is not consistent with other button colors
  • in FileExport, you don't need the context parameter, use the activity as a context
  • in RingUtility, use context to get resources, and don't pass the resources as a parameter, same with packageName
  • in RingUtility you have highly coupled code, write an interface that the activity implements that the util class uses to pass context back to the activity rather than calling UI code directly in the class.

@chaneylc
Copy link
Member

chaneylc commented Mar 7, 2024

Something with compare is still broken. It always defaults to matches mode on first load, even if contains is selected in the UI.
Reproduce:

  1. Open compare fragment, choose contains, close app
  2. Reopen app to compare, enter barcodes a then ab, the ui will say contains, but the result will be false because its actually matches

@chaneylc
Copy link
Member

Latest commits seem to break import. When I try importing a file, it imports but doesn't display any data. I checked and the data is in the database, but is not being displayed.

@chaneylc
Copy link
Member

In the latest commits color mode does not work anymore.

@chaneylc
Copy link
Member

chaneylc commented Mar 26, 2024

  • Audio is not working on first install until I reselect the setting
  • combine data in additional info recycler with default recycler, so there is smoother scrolling
  • export seems to be broken, it always exports an empty file
  • Clear the recycler view when an invalid barcode is scanned or the edit text is cleared, the app makes a plonk noise but still shows the old data.
  • keep fragments/activities on the backstack, right now back button closes the app.
  • When a list item is filtered, don't update the current scroll
  • coloring mode is broken

…y file, updating current scroll after list filtered, audio working after first install
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants