Added support for optional NSAttributedString, for cell text. #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, Tho. So, I wanted to use Apple's Symbols (as images) in my cells, so switched to using NSAttributedStrings with NSTextAttachments, for each UITableViewCell.
In this PR, I added support for an optional NSAttributedString to set the cell's attributedText instead. items are now an array of type BTItem, which is a struct I created with a String and an optional NSAttributedString. If a NSAttributedString is set for an item, it will use that instead.
I don't know if would be popular or not, since it is a breaking change with the previous array of Strings, for items, but otherwise it works the same. One would just pass in BTItem(string: "Text"), instead of "Text" for each element.
-Stu