Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DITTO L to CTS #18

Closed
wants to merge 1 commit into from
Closed

DITTO L to CTS #18

wants to merge 1 commit into from

Conversation

PonteIneptique
Copy link
Member

I'd prefer it not to be merged right now

I heard you liked tragedies and lines...

Logs :

I heard you liked tragedies and lines...
Logs :
Done through github api and research on "<step refunit="line" from="DESCENDANT (1 L N%1)" to="DITTO"/>"
Automatically transormed with https://github.com/PonteIneptique/automatic-github/blob/master/lines.py
CTS metadata from Catalog
@PonteIneptique
Copy link
Member Author

@srdee @balmas This PR needs to be checked (mostly cts.xml over written or stuff like that). I think for texts it should be ok...

@PonteIneptique
Copy link
Member Author

@srdee @balmas Reason why not merged : I want to have a go with testing it with current Hook

Feel free to do edits on this branch :')

@balmas
Copy link
Contributor

balmas commented Aug 10, 2015

@PonteIneptique
check out
https://github.com/PerseusDL/canonical-greekLit/blob/lines-tragedy/data/tlg0006/tlg008/tlg0006.tlg008.perseus-grc1.xml#L284
vs
https://github.com/PerseusDL/canonical-greekLit/blob/master/data/tlg0006/tlg008/tlg0006.tlg008.perseus-grc1.xml#L326

Line number changed by script. The script should check to be sure it isn't changing an existing line # and if it is, it needs to report an error and flag for manual review. Causes could be many. E.g. see
PerseusDL/canonical#95

@balmas
Copy link
Contributor

balmas commented Aug 10, 2015

Also see relevant issue PerseusDL/canonical#145

@balmas
Copy link
Contributor

balmas commented Aug 10, 2015

Also re refsDecl, can we automatically fixup language ident codes to use 3 char code for greek and latin (grc and lat) instead of greek and latin?

@PonteIneptique
Copy link
Member Author

greek and lat -> grc and lat That's a general script that should be run on the whole repo to deal with this.

numbering issue Mostly due to concurrent line numbering. For this precise file, see http://remacle.org/bloodwolf/tragediens/euripide/suppliantes.htm 78β and 86β and http://www.loebclassics.com/view/euripides-suppliant_women/1998/pb_LCL009.19.xml

@lcerrato
Copy link
Collaborator

I don't follow the line number question here. We should be following the Murray OUP.
Looks like there are line numbering issues that start back at l 45? Not sure what is happening beginning with that chorus, but there are problems there.
I see significant textual differences with the LCL in lines 72 -86 ff but I'm not sure how those are relevant to the numbering issue highlighted above, since we aren't using LCL. think the numbering goes awry earlier than that.

lcerrato pushed a commit that referenced this pull request Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants