Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(grc_conversion) EpiDoc and CTS conversion work #1692

Merged
merged 5 commits into from
Nov 15, 2024
Merged

Conversation

lcerrato
Copy link
Collaborator

@lcerrato lcerrato commented Nov 14, 2024

EpiDoc and CTS conversion tlg0555.tlg004 conversion and merge #1399

tlg0556.tlg001 also included.

@lcerrato
Copy link
Collaborator Author

@lcerrato lcerrato requested a review from AlisonBabeu November 14, 2024 18:25
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the work title in the file be: <title xml:lang="grc">Στρώματα</title> not <title xml:lang="lat">Stromata</title>

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It actually doesn't appear either way in print.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had expected to see the addition of tlg0556.tlg001.perseus-grc2 and tlg0555.tlg004.perseus-grc2 to the manifest, since those are different files added below.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't always push the manifest since it is generated server side. I have a backlog of changes locally so that may be where the update is. More soon.

@lcerrato lcerrato merged commit 550a3ed into master Nov 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants