-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(greek_conversion) EpiDoc and CTS conversion work #1528
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @lcerrato only thing I would change on this file is in the structured bibliography.
<title>Claudii Aeliani de natura animalium libri xvii, varia historia, epistolae, fragmenta, Vol 2</title>
I would delete Vol 2 here and add it in using the biblScope element!
The same is true for tlg0545.tlg002.perseus-grc3 below! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a biblScope element, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one more comment,need to standardize some structured bibliographic data.
<publisher>In Aedibus B.G. Teubneri</publisher> <pubPlace>Lipsiae</pubPlace>
Change these from Latin, move the volume number, and also missing a page level link to the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file doesn't appear to be completely done-- there are several header elements not updated such as release date, etc.
The PR is not ready to go. I stopped before doing a final check.
@AlisonBabeu I appreciate your looking at these: the headers were/are very confusing! |
…s-grc2 RK20231129
into greek_conversion * 'master' of https://github.com/PerseusDL/canonical-greekLit: (28 commits) Update tlg0099.tlg001.perseus-eng1.xml Fix `<speaker>—</speaker>` Fix a missing `<speaker>` tlg0062.tlg024_tlg032 tlg0014_tlg0062 Fix incorrect div type assignment Correctly identify translations Fix a handful of single-character typos Normalize `lang="greek"` => `lang="grc"` Normalize `<said><label/>...</said>` interaction tlg0099.tlg001.perseus-eng2 tlg0099.tlg001.perseus-eng1 tlg0086.tlg009.perseus-eng1 tlg0086.tlg010.perseus-eng1 tlg0086.tlg025.perseus-eng1 tlg0057.tlg010.perseus-eng1 tlg0086.tlg029.perseus-eng1 tlg0086.tlg034.perseus-eng1 tlg0086.tlg038.perseus-eng1 tlg0094.tlg001.perseus-eng1 ...
@AlisonBabeu Would you mind looking over the metadata here? I don't want to push more files/changes to this batch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So @lcerrato should this be tlg0555.tlg004.perseus-grc2? And also there is no cts_.xml file for the 004 directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlisonBabeu
I am not converting that file now per #1399 comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed an extra period in the file name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a comment on one file that needs a minor metadata change and there also appears to be a missing cts_.xml file for tlg0555.tlg004.
@AlisonBabeu Thank you. tlg0555.tlg004 is not being converted as part of this PR. |
tlg0545 batch #1399