Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tlg0003.tlg001.perseus-eng6.xml #1502

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Update tlg0003.tlg001.perseus-eng6.xml #1502

merged 2 commits into from
Sep 14, 2023

Conversation

lcerrato
Copy link
Collaborator

See #1472

@lcerrato
Copy link
Collaborator Author

8 changes have been checked in

  1. 1.11.3
  2. 1.38.6
  3. 1.65.3
  4. 1.110.5
  5. 3.3.6
  6. 3.40.8
  7. 3.85.4
  8. 4.102.4

@lcerrato
Copy link
Collaborator Author

Should be 8;917;3587 in book/chapter/section count

AlisonBabeu
AlisonBabeu reviewed Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@AlisonBabeu AlisonBabeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @lcerrato I'm a little confused here. The pull request lists a number of sections added and refers to an issue that describes missing Greek sections of text It looks like what was done here was correction of the tagging in some English translation text?

@lcerrato
Copy link
Collaborator Author

lcerrato commented Sep 14, 2023 •
edited
Loading

@AlisonBabeu
As these were not in the Greek, they needed to also be added to the translation. (The sections in this were all added by Perseus).
It made more sense when this was in one PR, but that got mysteriously closed on me so I had to start over. I could do the English online but had to do the Greek via Sourcetree.

AlisonBabeu
AlisonBabeu approved these changes Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@AlisonBabeu AlisonBabeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

@lcerrato lcerrato merged commit 948cdf2 into master Sep 14, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlisonBabeu AlisonBabeu AlisonBabeu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lcerrato @AlisonBabeu