Use country-list package instead of country_codes.json #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of relying on a giant JSON file in our codebase, let's use an NPM package that provides the dataset instead. This commit installs the country-list package as a dependency of web-app. Also install @types/country-list as a dev dependency, since country-list is a JavaScript library with no type definitions. PER-9256: Inaccurate names in country list
meisekimiu
force-pushed
the
remove-country-json
branch
from
109fb0e to
16b0325
Compare
Instead of including a JSON file in our own project, use the country-list package to get a list of country names and their codes instead. The country-list package supplies the overwrite function to allow users to inject in custom data for specific countries. It is used here to correct some information that is provided in the default country list. PER-9256: Inaccurate names in country list
Now that we use the country-list package, we don't need to keep the country_codes.json file that we were using before. Delete it. PER-9256: Inaccurate names in country list
meisekimiu
force-pushed
the
remove-country-json
branch
from
16b0325 to
34598d3
Compare
crisnicandrei
approved these changes
May 16, 2023
cecilia-donnelly
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR installs the country-list package as a dependency of web-app and uses it to generate the country list used in various parts of the app. Previously, we just had a big JSON file included in the project. As mentioned in #127, we want to stay away from including this kind of stuff in our project.
Fun fact: We only use the full country name and 2 character country code in the application, but the old
country_codes.jsonfile had a lot of other information on each country. The country-list package only has the information we want to use, and as a result it apparently trims down the compiled bundle size by about 55 kilobytes!Resolves PER-9256. 🇹🇼