Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use packages instead of vendored code #127

Open
jasonaowen opened this issue May 26, 2022 · 0 comments
Open

Use packages instead of vendored code #127

jasonaowen opened this issue May 26, 2022 · 0 comments

Comments

@jasonaowen
Copy link
Contributor

We have some third-party source code committed in src/vendor and src/style/vendor, and binary assets in src/assets and src/styles/fonts. Committing third-party code and assets to our repo makes it more difficult to keep up with upstream updates; makes it harder to properly assign credit; and, worse, allows for the possibility of local modifications - which makes it even harder to pull in upstream changes.

Replace the vendored code and assets with packaged versions.
jasonaowen added a commit that referenced this issue May 26, 2022
@jasonaowen
Remove unused GLYPHICONS font
a5818a0 
The GLYPHICONS Halflings set[1] is an icon set we are no longer using;
we removed the last reference to it in commit
b1954d9, which switched to the open
source Ionicons[2]. Remove the unused font files from our repo.

[1] https://www.glyphicons.com/sets/halflings/
[2] https://ionic.io/ionicons

Issue #127 Use packages instead of vendored code
This was referenced May 26, 2022
Merged
Merged
@meisekimiu meisekimiu mentioned this issue Jul 18, 2022
Merged
@meisekimiu meisekimiu mentioned this issue May 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jasonaowen