Trigger Zygisk modules service.sh in parallel #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
kevin01523
approved these changes
Nov 24, 2024
There was a problem hiding this comment.
Hmm looks fine to me but needs to be tested by @ThePedroo and by different users i guess
For scripts in late_start service mode, they should be executed in parallel, as explained in the official docs: https://github.com/topjohnwu/Magisk/blob/master/docs/guides.md#boot-scripts
GitHub CI is broken due to outdated gradle action
|
I have to update the gradle ci since it was broken in my repo, see evidence here: https://github.com/JingMatrix/ReZygisk/actions |
ThePedroo
added
bug
Trijal08
added a commit
to Trijal08/ReZygisk
that referenced
this pull request
Nov 25, 2024
fix: trigger Zygisk modules service.sh in parallel (PerformanC#91)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Change the way ReZygisk executing service.sh of zygisk modules.
Why
This will solve issue #90 and JingMatrix/LSPosed#62 so that LSPosed can run flawlessly with ReZygisk on Magisk.
See explanation in JingMatrix/LSPosed#62 (comment)_
Checkmarks
Additional information
If you have any additional information, write it here