Replaced [String] dependency url with [Package.Dependency] #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem with [String] urls was that inside the Package specification, we were running a map function that was inserting major version 2 for all the URLS. This is not the best way to deal. Reason: What if in some near future we add 1 more dependency? Will that dependency also take 2 as major version? Likely not. Solution: The current approach adds the ability to add fully satisfied dependency without the explict knowledge of mapping over.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Statement
The problem with [String] urls was that inside the Package
specification, we were running a map function that was inserting
major version 2 for all the URLS. This is not the best way to deal
although we only have 1 dependency at the moment.
Reason:
What if in some near future we add 1 more dependency?
Will that dependency also take 2 as major version? Likely not.
Solution:
The current approach adds the ability to add fully
satisfied dependency without the explicit knowledge of mapping over.