Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hardware section to metadata #927

Merged
merged 9 commits into from
Sep 20, 2023
Merged

Add hardware section to metadata #927

merged 9 commits into from
Sep 20, 2023

Conversation

LucasSilbernagel
Copy link
Contributor

@LucasSilbernagel LucasSilbernagel commented Sep 14, 2023 •
edited
Loading

Related epic

https://app.shortcut.com/xanaduai/epic/45372/users-can-see-example-code-that-demonstrates-how-demos-run-on-real-quantum-hardware-from-aws

Changes

  • Updated the demo metadata schema to include an optional hardware section (only to include AWS for the time being, but can accommodate more vendors in future)
  • Added the hardware metadata to 1 demo for testing purposes
  • Added AWS logo image asset

ashishks0522
ashishks0522 approved these changes Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@ashishks0522 ashishks0522 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ottoak
ottoak approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@ottoak ottoak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - let's just remember that Amazon will be creating new demos to host on our site to link to, so we'll have to change the demos we add these to for launch.

@LucasSilbernagel
Copy link
Contributor Author

LGTM - let's just remember that Amazon will be creating new demos to host on our site to link to, so we'll have to change the demos we add these to for launch.

For testing, should I maybe remove the hardware metadata from all but one of the four demos I added it to on this PR?

@ottoak
Copy link
Contributor

ottoak commented Sep 15, 2023

LGTM - let's just remember that Amazon will be creating new demos to host on our site to link to, so we'll have to change the demos we add these to for launch.

For testing, should I maybe remove the hardware metadata from all but one of the four demos I added it to on this PR?

I think that's a good idea!

josh146
josh146 approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@josh146 josh146 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LucasSilbernagel!

@LucasSilbernagel LucasSilbernagel merged commit bb4e726 into master Sep 20, 2023
6 checks passed
@LucasSilbernagel LucasSilbernagel deleted the add-hardware-section-to-metadata branch September 20, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashishks0522 ashishks0522 ashishks0522 approved these changes

@rashidnhm rashidnhm rashidnhm approved these changes

@doctorperceptron doctorperceptron doctorperceptron approved these changes

@ottoak ottoak ottoak approved these changes

@josh146 josh146 josh146 approved these changes

@BM7878 BM7878 Awaiting requested review from BM7878

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@LucasSilbernagel @ottoak @josh146 @doctorperceptron @rashidnhm @ashishks0522