New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LCU + Block encoding demo #888

Merged

KetpuntoG merged 49 commits into dev from lcu_blockencoding

Oct 26, 2023

Contributor

ixfoduap commented Aug 11, 2023

Last demo in the Rolls Royce QSVT series


          First draft of text sans code

50fe29c

ixfoduap self-assigned this

ixfoduap requested review from Jaybsoni and DSGuala

August 11, 2023 21:35

DSGuala and others added 2 commits

August 17, 2023 16:38


          fix typo to build preview

53cd64b


          Merge branch 'master' into lcu_blockencoding

9c250eb

github-actions bot commented Aug 17, 2023 •

edited

Loading

Thank you for opening this pull request.

You can find the built site at this link.

Deployment Info:

Pull Request ID: 888
Deployment SHA: 82ee2bff366f38f311b6aa28aa8ad09d86d1a36e
(The Deployment SHA refers to the latest commit hash the docs were built from)

Note: It may take several minutes for updates to this pull request to be reflected on the deployed site.

DSGuala reviewed

View reviewed changes

demonstrations/tutorial_lcu_blockencoding.py Outdated Show resolved Hide resolved

demonstrations/tutorial_lcu_blockencoding.py Outdated Show resolved Hide resolved

demonstrations/tutorial_lcu_blockencoding.py Outdated Show resolved Hide resolved

demonstrations/tutorial_lcu_blockencoding.py Outdated Show resolved Hide resolved

demonstrations/tutorial_lcu_blockencoding.py Outdated Show resolved Hide resolved

demonstrations/tutorial_lcu_blockencoding.py Outdated Show resolved Hide resolved

demonstrations/tutorial_lcu_blockencoding.py Outdated Show resolved Hide resolved

demonstrations/tutorial_lcu_blockencoding.py Outdated Show resolved Hide resolved

demonstrations/tutorial_lcu_blockencoding.py Outdated Show resolved Hide resolved

demonstrations/tutorial_lcu_blockencoding.py Outdated Show resolved Hide resolved

ixfoduap and others added 13 commits

August 17, 2023 17:39


          Apply suggestions from code review

40f3537

Co-authored-by: Diego <[email protected]>


          First complete draft sans images

cc63a4a


          Update demonstrations/tutorial_lcu_blockencoding.py

32e0de7

Co-authored-by: Diego <[email protected]>


          small edits

e6b79cc


          Merge branch 'lcu_blockencoding' of https://github.com/PennyLaneAI/qml …

78c0ad2

…into lcu_blockencoding


          First polished draft

d15aa5b


          Merge branch 'master' into lcu_blockencoding

cfad768


          update code to work with latest release

4c64eea


          change PL version, add placeholder images


          update poetry.lock as suggested by CI

fae6234


          Fix image paths

1dfbb7c


          fix image paths again

bc5a30a


          Merge branch 'master' into lcu_blockencoding

1271fe4

Jaybsoni requested changes

View reviewed changes

Contributor

Jaybsoni left a comment

Left a bunch of comments. I think the demo will still require some work before we can consider pushing it forward.

demonstrations/tutorial_lcu_blockencoding.metadata.json Outdated Show resolved Hide resolved

demonstrations/tutorial_lcu_blockencoding.py Outdated Show resolved Hide resolved

demonstrations/tutorial_lcu_blockencoding.py Outdated Show resolved Hide resolved

demonstrations/tutorial_lcu_blockencoding.py Show resolved Hide resolved

demonstrations/tutorial_lcu_blockencoding.py Outdated Show resolved Hide resolved

demonstrations/tutorial_lcu_blockencoding.py Outdated Show resolved Hide resolved

demonstrations/tutorial_lcu_blockencoding.py Outdated Show resolved Hide resolved

demonstrations/tutorial_lcu_blockencoding.py Outdated Show resolved Hide resolved

demonstrations/tutorial_lcu_blockencoding.py Outdated Show resolved Hide resolved

demonstrations/tutorial_lcu_blockencoding.py Outdated Show resolved Hide resolved

DSGuala and others added 5 commits

September 7, 2023 17:04


          Apply suggestions from code review

1e00920

Co-authored-by: Jay Soni <[email protected]>


          don't steal credit

21717cc


          add new images

e4d352a


          Merge branch 'master' into lcu_blockencoding

e42db64


          move images and change paths

0db85b3

KetpuntoG reviewed

View reviewed changes

Contributor

KetpuntoG left a comment

How cool to have a demo of LCU in pennylane! Very good work! 😊
I have left a first round of comments. There are a few technical issues that I think are the most important to address

demonstrations/tutorial_lcu_blockencoding.py Show resolved Hide resolved

demonstrations/tutorial_lcu_blockencoding.py Outdated Show resolved Hide resolved

demonstrations/tutorial_lcu_blockencoding.py Outdated Show resolved Hide resolved

demonstrations/tutorial_lcu_blockencoding.py Outdated Show resolved Hide resolved

demonstrations/tutorial_lcu_blockencoding.py Outdated Show resolved Hide resolved

demonstrations/tutorial_lcu_blockencoding.py Show resolved Hide resolved

demonstrations/tutorial_lcu_blockencoding.py Show resolved Hide resolved

demonstrations/tutorial_lcu_blockencoding.py Outdated Show resolved Hide resolved

demonstrations/tutorial_lcu_blockencoding.py Outdated Show resolved Hide resolved

demonstrations/tutorial_lcu_blockencoding.py Outdated Show resolved Hide resolved

DSGuala and others added 2 commits

September 8, 2023 15:10


          Merge branch 'master' into lcu_blockencoding

f301af9


          Apply suggestions from code review

82cc912

Co-authored-by: Jay Soni <[email protected]>

soranjh added 2 commits

October 13, 2023 14:57


          add small corrections

75ecf85


          update applications

4da576a

soranjh requested review from Jaybsoni, DSGuala and KetpuntoG

October 17, 2023 00:17

Jaybsoni approved these changes

View reviewed changes

Contributor

Jaybsoni left a comment

Looks good, two small suggestions

demonstrations/tutorial_lcu_blockencoding.py Outdated Show resolved Hide resolved

demonstrations/tutorial_lcu_blockencoding.py Outdated Show resolved Hide resolved


          add review comments

096b8c7

DSGuala approved these changes

View reviewed changes

Contributor

DSGuala left a comment

Looks good to me. I just left one suggestion to consider.

demonstrations/tutorial_lcu_blockencoding.py Outdated Show resolved Hide resolved


          add review comments

fd9c61f

soranjh requested a review from ikurecic

October 17, 2023 17:57

ikurecic reviewed

View reviewed changes

Contributor

ikurecic left a comment

Looks nice! :)
I have some minor comments/suggestions and some possible glossary terms @KetpuntoG might want to get made to replace the Wikipedia links.

demonstrations/tutorial_lcu_blockencoding.py Outdated Show resolved Hide resolved

demonstrations/tutorial_lcu_blockencoding.py Outdated Show resolved Hide resolved

demonstrations/tutorial_lcu_blockencoding.py Outdated Show resolved Hide resolved

demonstrations/tutorial_lcu_blockencoding.py Outdated Show resolved Hide resolved

demonstrations/tutorial_lcu_blockencoding.py Outdated Show resolved Hide resolved

demonstrations/tutorial_lcu_blockencoding.py Show resolved Hide resolved

demonstrations/tutorial_lcu_blockencoding.py Outdated Show resolved Hide resolved

demonstrations/tutorial_lcu_blockencoding.py Outdated Show resolved Hide resolved

demonstrations/tutorial_lcu_blockencoding.py Outdated Show resolved Hide resolved

demonstrations/tutorial_lcu_blockencoding.py Outdated Show resolved Hide resolved

soranjh added 2 commits

October 19, 2023 09:50


          add review comments

82840af


          add review comments

soranjh requested a review from ikurecic

October 19, 2023 19:20

ikurecic approved these changes

View reviewed changes

Contributor

ikurecic left a comment

Nice, looks great! :)

soranjh added the Completed/Ready label

KetpuntoG reviewed

View reviewed changes

demonstrations/tutorial_lcu_blockencoding.py Outdated Show resolved Hide resolved

demonstrations/tutorial_lcu_blockencoding.py Show resolved Hide resolved

demonstrations/tutorial_lcu_blockencoding.py Show resolved Hide resolved

demonstrations/tutorial_lcu_blockencoding.py Outdated Show resolved Hide resolved

demonstrations/tutorial_lcu_blockencoding.metadata.json Outdated Show resolved Hide resolved

KetpuntoG added 8 commits

October 20, 2023 13:21


          Update demonstrations/tutorial_lcu_blockencoding.py

8c3fc6d


          Update demonstrations/tutorial_lcu_blockencoding.py

fdb3dd5


          Update demonstrations/tutorial_lcu_blockencoding.py

71da7cd


          Update demonstrations/tutorial_lcu_blockencoding.py

5bb2737


          Update demonstrations/tutorial_lcu_blockencoding.metadata.json

a129a3f


          Merge branch 'dev' into lcu_blockencoding

1835bb7


          Merge branch 'dev' into lcu_blockencoding

131e367


          links to codebook + remove meta in .py

b53172a

DSGuala approved these changes

View reviewed changes

Contributor

DSGuala left a comment

Found a few typos. Otherwise good to go.

demonstrations/tutorial_lcu_blockencoding.py Outdated Show resolved Hide resolved

demonstrations/tutorial_lcu_blockencoding.py Outdated Show resolved Hide resolved

demonstrations/tutorial_lcu_blockencoding.py Outdated Show resolved Hide resolved

demonstrations/tutorial_lcu_blockencoding.py Outdated Show resolved Hide resolved

soranjh and others added 2 commits

October 23, 2023 16:15


          correct typos

f9eab6e


          update date + small typo in other demo

82ee2bf

KetpuntoG merged commit 429396a into dev

10 checks passed

KetpuntoG deleted the lcu_blockencoding branch

October 26, 2023 00:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

KetpuntoG KetpuntoG left review comments

soranjh soranjh left review comments

DSGuala DSGuala approved these changes

Jaybsoni Jaybsoni approved these changes

ikurecic ikurecic approved these changes

Labels

Completed/Ready