Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update QSVT on hardware how-to to use poly_to_angles #1273

Merged
merged 8 commits into from
Dec 6, 2024
Merged

Update QSVT on hardware how-to to use poly_to_angles #1273

merged 8 commits into from
Dec 6, 2024

Conversation

soranjh
Copy link
Contributor

@soranjh soranjh commented Dec 4, 2024

Summary:
The PR updates QSVT on hardware how-to to use PennyLane poly_to_angles function following [sc-79728].

@soranjh soranjh requested a review from KetpuntoG December 4, 2024 16:33
@soranjh soranjh changed the title add pl angles updates QSVT on hardware how-to to use PennyLane poly_to_angles Dec 4, 2024
@soranjh soranjh changed the title updates QSVT on hardware how-to to use PennyLane poly_to_angles Update QSVT on hardware how-to to use poly_to_angles Dec 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

👋 Hey, looks like you've updated some demos!

🐘 Don't forget to update the dateOfLastModification in the associated metadata files so your changes are reflected in Glass Onion (search and recommendations).

Please hide this comment once the field(s) are updated. Thanks!

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024 •
edited
Loading

Thank you for opening this pull request.

You can find the built site at this link.

Deployment Info:

  • Pull Request ID: 1273
  • Deployment SHA: 93a5d9d507c4b8469e92d6894f47c8838f04db41
    (The Deployment SHA refers to the latest commit hash the docs were built from)

Note: It may take several minutes for updates to this pull request to be reflected on the deployed site.

KetpuntoG
KetpuntoG requested changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@KetpuntoG KetpuntoG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see the functionality in action!
Could you update the last modification date in the metadata?

demonstrations/tutorial_qsvt_hardware.py Outdated Show resolved Hide resolved
KetpuntoG
KetpuntoG approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@KetpuntoG KetpuntoG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@KetpuntoG
Copy link
Contributor

I updated one cell to use the new qml.transform_angles functionality. Now it is perfect :)

@soranjh soranjh requested a review from Jaybsoni December 5, 2024 22:10
Jaybsoni
Jaybsoni approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@Jaybsoni Jaybsoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left one comment. Otherwise good to go from my side 👍🏼

@soranjh soranjh merged commit e5404df into dev Dec 6, 2024
10 checks passed
@soranjh soranjh deleted the qsvt_poly_to_angle branch December 6, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KetpuntoG KetpuntoG KetpuntoG approved these changes

@Jaybsoni Jaybsoni Jaybsoni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soranjh @KetpuntoG @Jaybsoni