Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Deprecated Github Actions #1233

Merged
merged 4 commits into from
Oct 11, 2024
Merged

Update Deprecated Github Actions #1233

merged 4 commits into from
Oct 11, 2024

Conversation

brownj85
Copy link
Contributor

@brownj85 brownj85 commented Oct 8, 2024 •
edited
Loading

Summary:

  • Updates actions/checkout to v4
  • Updates actions/setup-node to v4 and uses node version 20

Story
https://app.shortcut.com/xanaduai/story/60888/update-actions-checkout-version-in-qml-workflows

@brownj85 brownj85 changed the title Update Action Versions Update Deprecated Github Actioons Oct 8, 2024
@brownj85 brownj85 changed the title Update Deprecated Github Actioons Update Deprecated Github Actions Oct 8, 2024
Mandrenkov
Mandrenkov reviewed Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@Mandrenkov Mandrenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me. Is there a way to easily verify that the workflows still work?

@brownj85
Copy link
Contributor Author

brownj85 commented Oct 9, 2024

Looks reasonable to me. Is there a way to easily verify that the workflows still work?

With actions/setup-node, we can see it working here: https://github.com/PennyLaneAI/qml/actions/runs/11257971811

With actions/checkout, really hard to see anything breaking - the interface is unchanged and we don't use any fancy features. If anything does break it'll be a quick fix.

@brownj85 brownj85 requested a review from Mandrenkov October 9, 2024 15:28
doctorperceptron
doctorperceptron approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@doctorperceptron doctorperceptron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@brownj85 brownj85 enabled auto-merge (squash) October 11, 2024 15:49
@brownj85 brownj85 merged commit 3d9caef into master Oct 11, 2024
6 checks passed
@brownj85 brownj85 deleted the sc-60888-update-actions-checkout-version-in-qml-workflows branch October 11, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doctorperceptron doctorperceptron doctorperceptron approved these changes

@Mandrenkov Mandrenkov Mandrenkov approved these changes

@ashishks0522 ashishks0522 Awaiting requested review from ashishks0522

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brownj85 @Mandrenkov @doctorperceptron