Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How-to: Quantum Arithmetic #1229

Closed
wants to merge 45 commits into from
Closed

How-to: Quantum Arithmetic #1229

wants to merge 45 commits into from

Conversation

gmlejarza
Copy link
Collaborator

@gmlejarza gmlejarza commented Oct 4, 2024

Title: How to use Quantum Arithmetic Operators [sc-74430]

Summary: We show how to load a function into a quantum computer using Pennylane arithmetic operators.


If you are writing a demonstration, please answer these questions to facilitate the marketing process.

  • GOALS — Why are we working on this now?

Promote and make people understand how to use quantum arithmetic operators in Pennylane.

  • AUDIENCE — Who is this for?

Researchers working in quantum algorithms, beginners starting in quantum computing.

  • KEYWORDS — What words should be included in the marketing post?

Quantum Arithmetic, Loading functions into quantum computers, Addition, Multiplication,

  • Which of the following types of documentation is most similar to your file?
    (more details here)
  • How-to

@gmlejarza gmlejarza requested a review from KetpuntoG October 4, 2024 10:54
Copy link

github-actions bot commented Oct 4, 2024

👋 Hey, looks like you've updated some demos!

🐘 Don't forget to update the dateOfLastModification in the associated metadata files so your changes are reflected in Glass Onion (search and recommendations).

Please hide this comment once the field(s) are updated. Thanks!

Copy link

github-actions bot commented Oct 4, 2024

Thank you for opening this pull request.

You can find the built site at this link.

Deployment Info:

  • Pull Request ID: 1229
  • Deployment SHA: 17c2f32fdac6a34e184a24671a3ac95a83a3eecd
    (The Deployment SHA refers to the latest commit hash the docs were built from)

Note: It may take several minutes for updates to this pull request to be reflected on the deployed site.

Copy link
Contributor

@KetpuntoG KetpuntoG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @gmlejarza 🚀
I made a push to try to simplify the code as much as possible as it could be “intimidating” at first. In general everything is fine and to improve it I would try to be much more direct trying to keep this how-to short
On the other hand, if you have a thumbnail suggestion, I will request it on Monday 🎨

Copy link
Contributor

@ixfoduap ixfoduap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left suggestions 😈

demonstrations/tutorial_how_to_use_arithmetic_operators.py Outdated Show resolved Hide resolved
demonstrations/tutorial_how_to_use_arithmetic_operators.py Outdated Show resolved Hide resolved
demonstrations/tutorial_how_to_use_arithmetic_operators.py Outdated Show resolved Hide resolved
demonstrations/tutorial_how_to_use_arithmetic_operators.py Outdated Show resolved Hide resolved
demonstrations/tutorial_how_to_use_arithmetic_operators.py Outdated Show resolved Hide resolved
demonstrations/tutorial_how_to_use_arithmetic_operators.py Outdated Show resolved Hide resolved
demonstrations/tutorial_how_to_use_arithmetic_operators.py Outdated Show resolved Hide resolved
demonstrations/tutorial_how_to_use_arithmetic_operators.py Outdated Show resolved Hide resolved
demonstrations/tutorial_how_to_use_arithmetic_operators.py Outdated Show resolved Hide resolved
demonstrations/tutorial_how_to_use_arithmetic_operators.py Outdated Show resolved Hide resolved
@gmlejarza gmlejarza changed the title [WIP] How-to: Quantum Arithmetic How-to: Quantum Arithmetic Oct 10, 2024
Copy link
Contributor

@ixfoduap ixfoduap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more suggestions and this will be ready to go. Great job!

Copy link
Contributor

@ikurecic ikurecic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @KetpuntoG and @gmlejarza .
I've left some suggestions and corrections, but they are fairly minor. If you can address these, we can hopefully have this Demo ready for merging soon.

demonstrations/tutorial_how_to_use_arithmetic_operators.py Outdated Show resolved Hide resolved
demonstrations/tutorial_how_to_use_arithmetic_operators.py Outdated Show resolved Hide resolved
demonstrations/tutorial_how_to_use_arithmetic_operators.py Outdated Show resolved Hide resolved
demonstrations/tutorial_how_to_use_arithmetic_operators.py Outdated Show resolved Hide resolved
demonstrations/tutorial_how_to_use_arithmetic_operators.py Outdated Show resolved Hide resolved
demonstrations/tutorial_how_to_use_arithmetic_operators.py Outdated Show resolved Hide resolved
@KetpuntoG
Copy link
Contributor

It is important that the file name starts with “tutorial_” . Otherwise, the demo will not run and the outputs will not appear. I just updated it in the last commit

@ikurecic
Copy link
Contributor

ikurecic commented Nov 5, 2024

"Unresolved conversation" issue solved in #1255

@ikurecic ikurecic closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants