Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tutorial_How_to_optimize_QML_model_using_JAX_and_Optax.py #1052

Merged
merged 3 commits into from
Mar 11, 2024

Conversation

KetpuntoG
Copy link
Contributor

Solving issue #1045

As indicated in the issue, the optimizer being used within the update_step_jit function is not the one defined in the optimization_jit function. I tried to pass opt but it gave problems so I simply defined the optimizer outside.

In the case where jit is not being applied, I was able to pass the optimizer, so I updated those functions.
Tagging @josh146 in case there is a better solution in this case

Copy link

github-actions bot commented Mar 8, 2024

👋 Hey, looks like you've updated some demos!

🐘 Don't forget to update the dateOfLastModification in the associated metadata files so your changes show up on pennylane.ai.

Please hide this comment once the field(s) are updated. Thanks!

Copy link

github-actions bot commented Mar 8, 2024

Thank you for opening this pull request.

You can find the built site at this link.

Deployment Info:

  • Pull Request ID: 1052
  • Deployment SHA: ce3f10b1c00cd798ddeb77c5f79833e03de11fb8
    (The Deployment SHA refers to the latest commit hash the docs were built from)

Note: It may take several minutes for updates to this pull request to be reflected on the deployed site.

Copy link
Member

@josh146 josh146 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @KetpuntoG

Copy link
Contributor

@isaacdevlugt isaacdevlugt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@KetpuntoG KetpuntoG merged commit 380b289 into master Mar 11, 2024
10 checks passed
@KetpuntoG KetpuntoG deleted the fixing_jax_demo branch March 11, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants