Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RC/RC Lightning status. #76

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Add RC/RC Lightning status. #76

merged 2 commits into from
Apr 30, 2024

Conversation

vincentmr
Copy link
Contributor

@vincentmr vincentmr commented Apr 30, 2024

The release/release compatibility workflows are run here but the results are not reported in the test matrix. This PR adds a column to the freeze matrix and reports the tests status.

Relevant Shortcut Stories:
[sc-62303]

@vincentmr vincentmr requested review from mlxd, AmintorDusko and a team April 30, 2024 19:27
Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that Catalyst is only RC/RC/RC here now, so that should be moved in the table to match Lightning Rc/RC (hard to see where to comment)

@vincentmr
Copy link
Contributor Author

Note that Catalyst is only RC/RC/RC here now, so that should be moved in the table to match Lightning Rc/RC (hard to see where to comment)

Will do.

Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good now! Thank you for that!
Also, thank you for previously anticipating the necessity of this workflow.

@vincentmr
Copy link
Contributor Author

@mudit2812 I cannot merge on plugin-test-matrix, could you please do it?

@astralcai astralcai merged commit cc20127 into master Apr 30, 2024
27 of 43 checks passed
@trbromley trbromley deleted the feature/rc_rc branch May 1, 2024 12:45
@trbromley
Copy link
Contributor

Did we need this to be an extra column? Is latest/rc a useful datapoint for Lightning and Catalyst?

@vincentmr
Copy link
Contributor Author

Did we need this to be an extra column? Is latest/rc a useful datapoint for Lightning and Catalyst?

Being unsure whether to keep it or not, I erred on the side of caution and kept latest/rc. Would a single rc/rc column be clearer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants