Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TrotterProduct differentiability with parameter-shift #6432

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Fix TrotterProduct differentiability with parameter-shift #6432

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
ec9d121
parameter-shift matches backprop
andrijapau Oct 22, 2024
96bc0a0
add changelog entry
andrijapau Oct 22, 2024
2aa4d7f
skip diff for test case that is not unitary
andrijapau Oct 23, 2024
77e6e05
Merge branch 'master' into 6333-bug-trotter-diff
andrijapau Oct 24, 2024
60518ed
Update tests/ops/functions/conftest.py
andrijapau Oct 25, 2024
8d095d7
typo in committed suggestion
andrijapau Oct 25, 2024
03853c5
skip diff and add seperate custom diff check
andrijapau Oct 30, 2024
c47adbb
comment out failing test case
andrijapau Oct 31, 2024
f671300
Merge branch 'master' into 6333-bug-trotter-diff [skip-ci]
andrijapau Nov 8, 2024
e84c3f5
Merge branch 'master' into 6333-bug-trotter-diff
andrijapau Jan 2, 2025
f0753cd
fix: remove xfail from test_exp.py
andrijapau Jan 2, 2025
b005e6a
fix: Update test_differentiation to not use private _coeffs
andrijapau Jan 2, 2025
ea533bd
fix: Remove grad_method=None addition from trotter.py
andrijapau Jan 2, 2025
d074068
fix: Remove grad_method=None addition from exp.py
andrijapau Jan 2, 2025
0314e41
fix: Update test_trotter.py differentiation test
andrijapau Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions doc/releases/changelog-dev.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,6 +320,9 @@

<h3>Bug fixes 🐛</h3>

* Fixes incorrect differentiation of `TrotterProduct` when using `diff_method="parameter-shift"`.
[(#6432)](https://github.com/PennyLaneAI/pennylane/pull/6432)

* Patches the `math` module to function with autoray 0.7.0.
[(#6429)](https://github.com/PennyLaneAI/pennylane/pull/6429)

Expand Down
1 change: 1 addition & 0 deletions pennylane/ops/op_math/exp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,7 @@ class Exp(ScalarSymbolicOp, Operation):

"""

grad_method = None
control_wires = Wires([])
_name = "Exp"

Expand Down
2 changes: 2 additions & 0 deletions pennylane/templates/subroutines/trotter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,8 @@ def my_circ(c1, c2, time):
(tensor(0.00961064, requires_grad=True), tensor(-0.12338274, requires_grad=True), tensor(-5.43401259, requires_grad=True))
"""

grad_method = None

@classmethod
def _primitive_bind_call(cls, *args, **kwargs):
# accepts no wires, so bypasses the wire processing.
Expand Down
4 changes: 3 additions & 1 deletion tests/ops/functions/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,9 @@
(qml.s_prod(1.1, qml.RX(1.1, 0)), {}),
(qml.prod(qml.PauliX(0), qml.PauliY(1), qml.PauliZ(0)), {}),
(qml.ctrl(qml.RX(1.1, 0), 1), {}),
(qml.exp(qml.PauliX(0), 1.1), {}),
(qml.exp(qml.PauliX(0), 1.1), {"skip_differentiation": True}),
andrijapau marked this conversation as resolved.
Show resolved Hide resolved
(qml.exp(qml.PauliX(0), 2.9j), {}),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be ok with commenting this line out till we figure out what to do with the generator of Exp.

Suggested change
(qml.exp(qml.PauliX(0), 2.9j), {}),
#(qml.exp(qml.PauliX(0), 2.9j), {}),

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can xfail it and create an issue to track it?

(qml.evolve(qml.PauliX(0), -0.5), {}),
(qml.pow(qml.IsingXX(1.1, [0, 1]), 2.5), {}),
(qml.ops.Evolution(qml.PauliX(0), 5.2), {}),
(qml.QutritBasisState([1, 2, 0], wires=[0, 1, 2]), {"skip_differentiation": True}),
Expand Down
1 change: 0 additions & 1 deletion tests/templates/test_subroutines/test_trotter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,6 @@ def test_copy(self, hamiltonian, time, n, order):
assert op.hyperparameters == new_op.hyperparameters
assert op is not new_op

@pytest.mark.xfail(reason="https://github.com/PennyLaneAI/pennylane/issues/6333", strict=False)
@pytest.mark.parametrize("hamiltonian", test_hamiltonians)
def test_standard_validity(self, hamiltonian):
"""Test standard validity criteria using assert_valid."""
Expand Down