Add conversion support for Qiskit noise models #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #577 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 7 9 +2
Lines 554 867 +313
==========================================
+ Hits 554 867 +313 ☔ View full report in Codecov by Sentry. |
austingmhuang
requested changes
Jul 16, 2024
There was a problem hiding this comment.
Looking good @obliviateandsurrender! Don't think I totally understand how the tests work for the noise models at a detailed level but I think I get it on a high-level basis. Seems like you take a qiskit noise model -> quantum error map (converting qiskit errors to kraus matrices) -> pennylane noise model?
austingmhuang
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: Add support for converting Qiskit's noise models to PennyLane's noise models.
Description of the Change:
noise_models.pycontains helper methods for converting a Qiskit'sNoiseModelobject to a list of PennyLane Channel objects that are constructed based on their Kraus representation obtained via Qiskit.converter.pycontains theload_noise_modelmethod, which accepts a Qiskit noise model along with some mentioned keyword arguments and returns the corresponding PennyLane noise model.Benefits:
Noise model construction can be done in PennyLane from a Qiskit one.
Possible Drawbacks:
QubitChannelswill only give Kraus representation and not any information on the corresponding error.Related GitHub Issues: [sc-68045]