-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compat workflows. #498
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #498 +/- ##
=======================================
Coverage 99.13% 99.13%
=======================================
Files 142 142
Lines 16798 16798
=======================================
Hits 16652 16652
Misses 146 146
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few queries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @vincentmr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small suggestion. Thank you for that.
Co-authored-by: Amintor Dusko <[email protected]>
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
SC-43411 requires compatibility tests between PennyLane and Lightning's most recent stable releases and development versions.
Description of the Change:
This PR adds
compat
-workflows calling the Linux and no-binary test workflows withlightning-version
andpennylane-version
inputs. These inputs are then used to switch betweenstable
andlatest
versions.Benefits:
Possible Drawbacks:
Related GitHub Issues:
PennyLaneAI/plugin-test-matrix#50