Changed ValueRange to ResultRange and Value to OpResult in Gate_Op #1426
+20
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d UnitaryGate_Op on ..QubitResults()
dime10
reviewed
Jan 9, 2025
There was a problem hiding this comment.
Thanks @sengthai! Could you add a changelog entry under the Internal Changes section? :)
Additionally, the original issue also describes updating the places in our code where we use these functions, specifically to simplify calling replaceAllUses.
|
Thank you for nice feedback, @dime10. I'lll modify and add in changelog right away. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
This PR updates
gate_opby replacingValueRangewithResultRangeandValuewithOpResultto better align with the semantics of**QubitResult()functions likegetNonCtrlQubitResults(). This change ensures clearer intent and usage.Related GitHub Issues:
#1192