Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable partially entangling ms gates #101

Merged
merged 15 commits into from
Apr 30, 2024
Merged

enable partially entangling ms gates #101

merged 15 commits into from
Apr 30, 2024

Conversation

splch
Copy link
Contributor

@splch splch commented Apr 16, 2024

adds a third parameter for the ms gate that defaults to 0.25 (fully entangling). can be changed to enable partial entanglement.

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.06%. Comparing base (a7d2d30) to head (8094647).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
- Coverage   96.85%   96.06%   -0.80%     
==========================================
  Files           5        5              
  Lines         318      330      +12     
==========================================
+ Hits          308      317       +9     
- Misses         10       13       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@trbromley trbromley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @splch! I'll tag someone from the team to take a second look.

pennylane_ionq/ops.py Outdated Show resolved Hide resolved
@trbromley trbromley requested a review from a team April 17, 2024 17:15
Co-authored-by: Thomas R. Bromley <[email protected]>
@splch
Copy link
Contributor Author

splch commented Apr 17, 2024

thanks! i appreciate the suggestion too :)

pennylane_ionq/ops.py Outdated Show resolved Hide resolved
Copy link
Contributor

@albi3ro albi3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward enough.

Mind adding a change log entry at:

https://github.com/PennyLaneAI/PennyLane-IonQ/blob/master/CHANGELOG.md

@trbromley trbromley requested a review from albi3ro April 23, 2024 16:43
@trbromley
Copy link
Contributor

Thanks @splch! Looks like it's nearly there, but missing a test that passes the theta parameter. Are you able to add that in?

@trbromley trbromley removed the request for review from albi3ro April 23, 2024 16:47
@splch
Copy link
Contributor Author

splch commented Apr 30, 2024

Thanks @splch! Looks like it's nearly there, but missing a test that passes the theta parameter. Are you able to add that in?

hi! thanks for the feedback :) is this what you were thinking of for theta testing? https://github.com/PennyLaneAI/PennyLane-IonQ/pull/101/files#diff-72107d6f4a703abaeb6a7cf709e0c99f7ed0b7c74f0b14b0cbc4f35c7c650e26R369-R389

@Alex-Preciado
Copy link
Contributor

Thank you so much for this contribution @splch !! We have double checked and the Codecov failures seem unrelated to the changes made in this PR. Force merging now!! 🚀

@Alex-Preciado Alex-Preciado merged commit b1b5d46 into PennyLaneAI:master Apr 30, 2024
8 of 9 checks passed
@splch splch deleted the partial-ms-entanglement branch May 6, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants