-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable partially entangling ms gates #101
enable partially entangling ms gates #101
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #101 +/- ##
==========================================
- Coverage 96.85% 96.06% -0.80%
==========================================
Files 5 5
Lines 318 330 +12
==========================================
+ Hits 308 317 +9
- Misses 10 13 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @splch! I'll tag someone from the team to take a second look.
Co-authored-by: Thomas R. Bromley <[email protected]>
thanks! i appreciate the suggestion too :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks straightforward enough.
Mind adding a change log entry at:
https://github.com/PennyLaneAI/PennyLane-IonQ/blob/master/CHANGELOG.md
Thanks @splch! Looks like it's nearly there, but missing a test that passes the |
hi! thanks for the feedback :) is this what you were thinking of for theta testing? https://github.com/PennyLaneAI/PennyLane-IonQ/pull/101/files#diff-72107d6f4a703abaeb6a7cf709e0c99f7ed0b7c74f0b14b0cbc4f35c7c650e26R369-R389 |
Thank you so much for this contribution @splch !! We have double checked and the Codecov failures seem unrelated to the changes made in this PR. Force merging now!! 🚀 |
adds a third parameter for the ms gate that defaults to
0.25
(fully entangling). can be changed to enable partial entanglement.