Update CSS fonts to cover every symbol used in a deck name so far #11711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And add a script that, although a bit rubbish, gives us a fighting chance of being able to do this again in the future when more symbols get added. Just adding these fonts without subsetting is a complete no-go as the CJK one is 15MB. See #8823.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #11711 +/- ##
==========================================
- Coverage 49.89% 49.74% -0.16%
==========================================
Files 304 305 +1
Lines 16927 16983 +56
Branches 2531 2545 +14
==========================================
+ Hits 8446 8448 +2
- Misses 8162 8217 +55
+ Partials 319 318 -1
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And add a script that, although a bit rubbish, gives us a fighting chance of being able to do this again in the future when more symbols get added.
Just adding these fonts without subsetting is a complete no-go as the CJK one is 15MB.
See #8823.