-
Notifications
You must be signed in to change notification settings - Fork 5
One dollar price limit #15
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot of changes here and as discussed this code is no longer in use.
If you want to build something to find $1 and below cards in a similar way to the Penny Dreadful checker it's probably worth building on top of rotation_script.py in the PennyDreadfulTools repo instead.
That said feel free to fork here and do whatever makes sense to you if that's easier.
FileConverter.writeFile(0, "Count.txt"); | ||
} | ||
int count = FileConverter.readToInt("Count.txt"); | ||
|
||
//Increase the count of how many times this program has been run, and update the text file to reflect that. | ||
count++; | ||
|
||
if (count < TIMES_CHECKED){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit. This change makes sense but ideally would be in a separate commit for ease of review.
} | ||
if (!new File("Count.txt").exists()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit. If we're changing (or maybe "settling on") brace style then we should apply it throughout.
@@ -62,19 +71,27 @@ public static void main(String[] args) throws Exception{ | |||
legalCards.add(card); | |||
} | |||
|
|||
//Add to an array all cards that were equal or below $1 50% or more of the time | |||
List<String> dollarLegalCards = new ArrayList<>(); | |||
for (String card : timesLegalMap.keySet()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this differ from the check for 1c cards? It seems like it's doing the same thing?
No description provided.