Skip to content
This repository has been archived by the owner on May 15, 2020. It is now read-only.

One dollar price limit #15

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

One dollar price limit #15

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 2, 2018

No description provided.

Copy link
Member

@bakert bakert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot of changes here and as discussed this code is no longer in use.

If you want to build something to find $1 and below cards in a similar way to the Penny Dreadful checker it's probably worth building on top of rotation_script.py in the PennyDreadfulTools repo instead.

That said feel free to fork here and do whatever makes sense to you if that's easier.

FileConverter.writeFile(0, "Count.txt");
}
int count = FileConverter.readToInt("Count.txt");

//Increase the count of how many times this program has been run, and update the text file to reflect that.
count++;

if (count < TIMES_CHECKED){
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit. This change makes sense but ideally would be in a separate commit for ease of review.

}
if (!new File("Count.txt").exists())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit. If we're changing (or maybe "settling on") brace style then we should apply it throughout.

@@ -62,19 +71,27 @@ public static void main(String[] args) throws Exception{
legalCards.add(card);
}

//Add to an array all cards that were equal or below $1 50% or more of the time
List<String> dollarLegalCards = new ArrayList<>();
for (String card : timesLegalMap.keySet()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this differ from the check for 1c cards? It seems like it's doing the same thing?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant