Add TimeKeeper to extension list #159
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
you didnt actually add the thumbnail fail |
…s/SparkyCreations/TimeKeeper.png
…ons/TimeKeeper.svg
|
why did you change something thats not a part of your ext at all??? |
|
it needs a bit of formatting but sp said he'd do that for you. |
|
ill review this again tomorrow bc its late |
|
sorry i accidentally deleted some of the letters so i just guessed the capitilzation |
|
i did everything you said too btw |
| this.timers[timerName] = 0; | ||
| this.countUpValues[timerName] = countUpValue; | ||
| this.intervals[timerName] = setInterval(() => { | ||
| this.timers[timerName] += this.countUpValues[timerName]; |
There was a problem hiding this comment.
You shouldn't do this, as many timers all doing this at once will cause lag.
You should set up a separate function that updates all values at once instead of individually
There was a problem hiding this comment.
The thumbnail should be 600x300. Otherwise it will be stretched
| (function(Scratch) { | ||
| class PauseResumeExtension { | ||
| constructor(runtime) { | ||
| this.runtime = runtime; |
|
The reviews still aren't resolved |
|
marking as draft bc of lack of input from submitter |
time keeper is an extension of the timer related blocks. it contains custom timers and more. (sorry for bad thumbnail)