Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby Analytics #115

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Ruby Analytics #115

wants to merge 3 commits into from

Conversation

Gen1x-ALT
Copy link
Contributor

it's worth noticing that this extension doesn't simply record stuff and save it into localstorage, it saves those numbers to our servers!

Copy link

vercel bot commented Jan 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
penguinmod-extensions-gallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2024 3:20am

@JoshAtticus
Copy link
Member

Looks cool, can I see the server code? Also we'd likely need @JeremyGamer13 to update the Privacy Policy.

@JeremyGamer13
Copy link
Member

likely privacy policy update again & ideally penguinmod (we need to add it) should place a warning that certain info is being tracked
do note that your servers WILL 100% be spammed with requests (thousands per project, per user depending on what happens during development)

@cicerorph
Copy link
Contributor

Jeremy we have knowledge of what can happen, as of such we decided to secure it firstly before releasing and making an ratelimit system.

@Gen1x-ALT
Copy link
Contributor Author

likely privacy policy update again & ideally penguinmod (we need to add it) should place a warning that certain info is being tracked do note that your servers WILL 100% be spammed with requests (thousands per project, per user depending on what happens during development)

yeah don't worry man we thought this through
we currently have a rate limit of 1000 requests per second for a single IP

and before you ask what service we use, mubi said they use this npm package, that we are not related to and it may have its own privacy policy

@SharkPool-SP SharkPool-SP requested review from SharkPool-SP and removed request for SharkPool-SP February 17, 2024 05:30
@SharkPool-SP
Copy link
Collaborator

I cant edit it. Allow us to edit the file so I can actually merge it

@SharkPool-SP SharkPool-SP self-requested a review February 17, 2024 05:36
@Gen1x-ALT Gen1x-ALT marked this pull request as draft February 17, 2024 05:42
@Gen1x-ALT Gen1x-ALT marked this pull request as ready for review February 17, 2024 05:43
@cicerorph
Copy link
Contributor

The pr is now editable

@SharkPool-SP
Copy link
Collaborator

The pr is now editable

its not.

@SharkPool-SP SharkPool-SP removed their request for review February 18, 2024 05:07
@SharkPool-SP SharkPool-SP marked this pull request as draft June 8, 2024 04:45
@SharkPool-SP SharkPool-SP marked this pull request as draft June 8, 2024 04:45
@SharkPool-SP SharkPool-SP marked this pull request as draft June 8, 2024 04:45
@SharkPool-SP
Copy link
Collaborator

Marking as Draft due to recent events and lack of input from creator

@Ianyourgod
Copy link
Member

why was it marked 3 times 💀

@dumorando
Copy link

seems like the api is being hosted on vercel. how's the bank account doin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants