Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid duplicates in select menus (with yadcf) #102

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

pankus
Copy link

@pankus pankus commented Aug 25, 2017

... this small piece of code works quite well for my needs, but I can't figure it out whitin different situation

@codecov
Copy link

codecov bot commented Aug 25, 2017

Codecov Report

Merging #102 into master will decrease coverage by 0.45%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
- Coverage   93.68%   93.22%   -0.46%     
==========================================
  Files           1        1              
  Lines         190      192       +2     
==========================================
+ Hits          178      179       +1     
- Misses         12       13       +1
Impacted Files Coverage Δ
datatables/__init__.py 93.22% <50%> (-0.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1e686a...6912cb2. Read the comment docs.

@tdamsma
Copy link
Collaborator

tdamsma commented Aug 30, 2017

This seems like a good change, but there is no test coverage for this. @pankus , do you feel comfortable adding a test that reproduces the desired behaviour? I don't have time right now to look into this, but will do eventually

@pankus
Copy link
Author

pankus commented Aug 31, 2017

I can try, even if I don't know where to start !!

natural sort method for PostgreSQL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants