Don't identify incoming connections for peers already in

address book
Peergos · Dec 5, 2023 · 8b6dd6f · 8b6dd6f
1 parent b70d043
commit 8b6dd6f
Showing 1 changed file with 14 additions and 11 deletions.
diff --git a/src/main/java/org/peergos/HostBuilder.java b/src/main/java/org/peergos/HostBuilder.java
@@ -184,16 +184,19 @@ public static Host build(PrivKey privKey,
                 addrs.addAddrs(remotePeer, 0, remote);
                 if (connection.isInitiator())
                     return;
-                StreamPromise<IdentifyController> stream = connection.muxerSession()
-                        .createStream(new IdentifyBinding(new IdentifyProtocol()));
-                stream.getController()
-                        .thenCompose(IdentifyController::id)
-                        .thenAccept(remoteId -> {
-                            Multiaddr[] remoteAddrs = remoteId.getListenAddrsList()
-                                    .stream()
-                                    .map(bytes -> Multiaddr.deserialize(bytes.toByteArray()))
-                                    .toArray(Multiaddr[]::new);
-                            addrs.getAddrs(remotePeer).thenAccept(existing -> {
+                addrs.getAddrs(remotePeer).thenAccept(existing -> {
+                    if (existing.isEmpty())
+                        return;
+                    StreamPromise<IdentifyController> stream = connection.muxerSession()
+                            .createStream(new IdentifyBinding(new IdentifyProtocol()));
+                    stream.getController()
+                            .thenCompose(IdentifyController::id)
+                            .thenAccept(remoteId -> {
+                                Multiaddr[] remoteAddrs = remoteId.getListenAddrsList()
+                                        .stream()
+                                        .map(bytes -> Multiaddr.deserialize(bytes.toByteArray()))
+                                        .toArray(Multiaddr[]::new);
+
                                 addrs.addAddrs(remotePeer, 0, remoteAddrs);
                                 List<String> protocolIds = remoteId.getProtocolsList().stream().collect(Collectors.toList());
                                 if (protocolIds.contains(Kademlia.WAN_DHT_ID) && wan.isPresent()) {
@@ -204,7 +207,7 @@ public static Host build(PrivKey privKey,
                                         connection.muxerSession().createStream(wan.get());
                                 }
                             });
-                        });
+                });
             });
 
             for (String listenAddr : listenAddrs) {