V0.4 #31
Open
V0.4 #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…django-graphql-auth into refactor-fields-logic
Drop Exclude Fields support and use Fields
ulgens
requested changes
May 23, 2020
| "email", | ||
| "username", | ||
| "last_login", | ||
| "isStaff", |
There was a problem hiding this comment.
Are we looking for Django field names or Node field names here? The list is inconsistent.
There was a problem hiding this comment.
These are the fields we want to be available in the user node.
There was a problem hiding this comment.
I mean, some of the fields have underscore and others are camel case.
There was a problem hiding this comment.
You are right, I didn't see that. Should be with underscore.
|
@PedroBern What is the plan for this PR? |
|
@ulgens I think we can close it. What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.