Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies: PyJWT and django-graphql-jwt #121

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lucmult
Copy link

@lucmult lucmult commented Jul 5, 2021

Currently other JWT libraries that used with django-graphql require PyJWT > 2.0, e.g: django-graphql-jwt

Remove PyJWT from the dependencies from django-graphsql-auth is safe because this isn't imported directly here.

Upgraded django-graphql-jwt from 0.3.0 to 0.3.2.

I've run the following tests locally:

$ make test
...
  py38-django30: commands succeeded
  congratulations :)

Lint and format run locally too.

@lucmult
Copy link
Author

lucmult commented Jul 5, 2021

This should fix #111

@amorino
Copy link

amorino commented Jul 22, 2021

This is great.

@cadiente-jomel
Copy link

@PedroBern can you merge this PR?

@pors
Copy link
Collaborator

pors commented Feb 3, 2022

Did you actually get it to install? I cloned it with your modifications and did:

cd django-graphql-auth
pip install -e .

result:

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
gql 2.0.0 requires graphql-core<3,>=2.3.2, but you have graphql-core 3.1.7 which is incompatible.
Successfully installed PyJWT-2.3.0 aniso8601-9.0.1 django-graphql-auth-0.3.16 django-graphql-jwt-0.3.2 graphene-3.0 graphene_django-3.0.0b7 graphql-core-3.1.7 graphql-relay-3.1.5

@PabloCastellano
Copy link

Please, can we get this trivial PR merged? 🙏

@pors
Copy link
Collaborator

pors commented Mar 15, 2022

Please, can we get this trivial PR merged? 🙏

@PabloCastellano I think it is not that trivial, see my comment above. These dependencies exist for a reason.

@PabloCastellano
Copy link

@pors That error is not related to this PR. If you clone master and do the same, you'll get incompatibilities too:

ERROR: graphql-relay 3.1.5 has requirement graphql-core<3.2,>=3.1, but you'll have graphql-core 2.3.2 which is incompatible.
ERROR: graphene 3.0 has requirement graphql-core~=3.1.2, but you'll have graphql-core 2.3.2 which is incompatible.
ERROR: graphene-django 2.15.0 has requirement graphene<3,>=2.1.7, but you'll have graphene 3.0 which is incompatible.

@PabloCastellano
Copy link

@pors check out my pr #147 which supersedes this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants