-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies: PyJWT and django-graphql-jwt #121
base: master
Are you sure you want to change the base?
Conversation
This should fix #111 |
This is great. |
@PedroBern can you merge this PR? |
Did you actually get it to install? I cloned it with your modifications and did:
result:
|
Please, can we get this trivial PR merged? 🙏 |
@PabloCastellano I think it is not that trivial, see my comment above. These dependencies exist for a reason. |
@pors That error is not related to this PR. If you clone master and do the same, you'll get incompatibilities too:
|
Currently other JWT libraries that used with django-graphql require PyJWT > 2.0, e.g: django-graphql-jwt
Remove PyJWT from the dependencies from django-graphsql-auth is safe because this isn't imported directly here.
Upgraded django-graphql-jwt from 0.3.0 to 0.3.2.
I've run the following tests locally:
$ make test ... py38-django30: commands succeeded congratulations :)
Lint and format run locally too.