Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to STICS wrappers to use stics R packages #3274

Merged
merged 76 commits into from
Apr 17, 2024
Merged

update to STICS wrappers to use stics R packages #3274

merged 76 commits into from
Apr 17, 2024

Conversation

istfer
Copy link
Contributor

@istfer istfer commented Mar 8, 2024 •
edited
Loading

Description

Updates STICS wrappers to increase control over model configuration

Motivation and Context

STICS team has published R packages to interact with the model. This PR utilizes those R packages.

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@istfer
registry file for site level CF format FO inputs
8265b29
@istfer
update met2model
8cab98a
@istfer
Merge branch 'develop' of https://github.com/PecanProject/pecan into …
a826db2 
…stics_packages

merge dev
@istfer
first case of set_param_xml
11568e2
@istfer
xml to txt
24d5c20
@istfer
vary more parameters
409100d
@istfer
handle until ini file
7b99903
@istfer
until weather
05a9e24
@istfer
until tec
5786115
@istfer
first pass at tec file
8fb2ef3
@istfer
save status
02e7b1f
@istfer
fixes for tec file
3979d19
@istfer
use new templates
6e698e6
@istfer
move mod files to the package
fd4c8d3
@istfer
set usm dir
f727878
@istfer
fix error log dir
5e17d79
@istfer
minor revision to model2netcdf
04c3893
@istfer
first pass for multiple usms
7becb2a
@istfer
Merge branch 'develop' of https://github.com/PecanProject/pecan into …
ebbc3e6 
…stics_packages

sync develop
@istfer
changes to fix met input workflow
dc6c0c1
@istfer
switch using json for management
96f5296
@istfer
change tag
25cb6f8
@istfer
better params
18ee073
@istfer
remove hack
2eca999
@istfer
Merge branch 'develop' of https://github.com/PecanProject/pecan into …
102330e 
…stics_packages
@istfer
vary phasic development parameters
9069113
@istfer
varying emergence parameters
cf0f179
@istfer
vary leaves params
55b3b68
@istfer
vary more
ae1c2ba
@istfer
pass cutting height
3957650
infotroph
infotroph reviewed Mar 8, 2024
View reviewed changes
base/db/R/dbfiles.R Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the Base label Mar 8, 2024
infotroph
infotroph approved these changes Mar 8, 2024
View reviewed changes
models/stics/DESCRIPTION Outdated Show resolved Hide resolved
models/stics/R/model2netcdf.STICS.R Show resolved Hide resolved
models/stics/R/write.config.STICS.R Outdated Show resolved Hide resolved
models/stics/R/write.config.STICS.R Show resolved Hide resolved
models/stics/inst/prof.mod Show resolved Hide resolved
@infotroph infotroph added this pull request to the merge queue Apr 17, 2024
Merged via the queue into PecanProject:develop with commit da9de52 Apr 17, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infotroph infotroph infotroph approved these changes

Assignees
No one assigned
Labels
Dockerfile Models Modules Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@istfer @infotroph