Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Notes in PEcAn.workflow #3261

Merged
merged 4 commits into from
Feb 18, 2024
Merged

Fixing Notes in PEcAn.workflow #3261

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4a19b29
fixed notes
meetagrawal09 Feb 17, 2024
c82318c
Merge branch 'develop' into fix-checks
meetagrawal09 Feb 17, 2024
92c33aa
Updated run.write.configs.R
meetagrawal09 Feb 17, 2024
089f2c7
commented un-used var
Feb 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions base/workflow/DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: PEcAn.workflow
Type: Package
Title: PEcAn functions used for ecological forecasts and
reanalysis
Title: PEcAn Functions Used for Ecological Forecasts and
Reanalysis
meetagrawal09 marked this conversation as resolved.
Show resolved Hide resolved
Version: 1.7.2
Date: 2021-10-04
Authors@R: c(person("Mike", "Dietze", role = c("aut"),
Expand Down
16 changes: 2 additions & 14 deletions base/workflow/tests/Rcheck_reference.log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,6 @@ Strong dependencies not in mainstream repositories:
PEcAn.data.atmosphere, PEcAn.data.land, PEcAn.DB, PEcAn.logger,
PEcAn.remote, PEcAn.settings, PEcAn.uncertainty, PEcAn.utils

The Title field should be in title case. Current version is:
‘PEcAn functions used for ecological forecasts and reanalysis’
In title case that is:
‘PEcAn Functions Used for Ecological Forecasts and Reanalysis’

The Date field is over a month old.
* checking package namespace information ... OK
* checking package dependencies ... OK
Expand Down Expand Up @@ -93,14 +88,7 @@ Maintainer field differs from that derived from Authors@R
* checking S3 generic/method consistency ... OK
* checking replacement functions ... OK
* checking foreign function calls ... OK
* checking R code for possible problems ... NOTE
run.write.configs: no visible binding for global variable
‘trait.samples’
run.write.configs: no visible binding for global variable ‘sa.samples’
run.write.configs: no visible binding for global variable
‘ensemble.samples’
Undefined global functions or variables:
ensemble.samples sa.samples trait.samples
* checking R code for possible problems ... OK
* checking Rd files ... OK
* checking Rd metadata ... OK
* checking Rd line widths ... OK
Expand All @@ -119,4 +107,4 @@ Undefined global functions or variables:
* checking for detritus in the temp directory ... OK
* DONE

Status: 1 WARNING, 2 NOTEs
Status: 1 WARNING, 1 NOTEs
Loading