Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Actions to R4.2 #3234

Merged
merged 3 commits into from
Nov 30, 2023
Merged

Update Actions to R4.2 #3234

merged 3 commits into from
Nov 30, 2023

Conversation

mdietze
Copy link
Member

@mdietze mdietze commented Nov 21, 2023

Swaps the outdated R4.0 build to R4.2 to see if that version builds successfully -- was overdue and might get the GH Actions working again.

Description

Motivation and Context

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Swaps the outdated R4.0 build to R4.2 to see if that version builds successfully -- was overdue and might get the GH Actions working again.
@mdietze
Copy link
Member Author

mdietze commented Nov 21, 2023

@robkooper @infotroph clearly I missed a step here as R4.2 fails immediately as it's looking for the Docker container pecan/depends:R4.2 which doesn't exist? How do I bump the building of the pecan/depends container to be able to bump the version used for GH Actions PR testing?

@infotroph
Copy link
Member

What you're missing is a piece I've been meaning to push all week! I'll open it as a separate PR that will need to be merged and then wait for the container to build before this one can use it.

@infotroph infotroph mentioned this pull request Nov 22, 2023
13 tasks
@infotroph infotroph mentioned this pull request Nov 25, 2023
13 tasks
Copy link
Member

@infotroph infotroph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and I agree it's time ot give up on 4.0 -- the Rocker image it's built on is just too far out of date now.

4.1 checks are passing at the moment; I'll work on getting 4.2 passing in #3237

@infotroph infotroph added this pull request to the merge queue Nov 30, 2023
Merged via the queue into develop with commit 2f0793f Nov 30, 2023
7 of 12 checks passed
@infotroph infotroph deleted the R4_2_Actions branch November 30, 2023 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants