Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Integration Tests for download.AmerifluxLBL #3208

Merged
merged 8 commits into from
Aug 28, 2023

Conversation

meetagrawal09
Copy link
Collaborator

Description

This PR aims to add integration tests for the data item : AmerifluxLBL

Review Time Estimate

  • Immediately
  • Within one week
  • When possible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • My name is in the list of CITATION.cff
  • I have updated the CHANGELOG.md.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@meetagrawal09 meetagrawal09 marked this pull request as draft August 6, 2023 05:18
Copy link
Member

@mdietze mdietze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this PR and the other met download PRs do represent useful tests of whether the underlying APIs we use are responding, they aren't actually integration tests. I'm not even sure they count as unit tests since they're not actually testing the download functions that we're currently using. (aside: I wonder if it'd be possible, once files are downloaded in the current piecemeal fashion, to use them in mocking the responses to the overall function unit tests). More importantly, they current unit tests are definitely not integration testing the larger met.process workflow. As such, I worry that we may be missing opportunities to identify the larger issues in that workflow and are investing time in fixing things that may not be the parts that are actually broken.

@meetagrawal09 meetagrawal09 marked this pull request as ready for review August 24, 2023 13:26
@mdietze mdietze added this pull request to the merge queue Aug 24, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 24, 2023
@mdietze mdietze added this pull request to the merge queue Aug 24, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 24, 2023
@mdietze mdietze added this pull request to the merge queue Aug 28, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 28, 2023
@mdietze mdietze added this pull request to the merge queue Aug 28, 2023
Merged via the queue into PecanProject:develop with commit ce327b9 Aug 28, 2023
12 checks passed
@meetagrawal09 meetagrawal09 deleted the test-AmerifluxLBL branch August 28, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants