Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace testthat funs used in package code #3016

Merged
merged 5 commits into from
Aug 25, 2022
Merged

Replace testthat funs used in package code #3016

merged 5 commits into from
Aug 25, 2022

Conversation

Aariq
Copy link
Collaborator

@Aariq Aariq commented Aug 22, 2022 •
edited
Loading

Adresses #2987
testthat is meant for testing, and not for using inside of functions. This replaces testthat functions with stopifnot() or if(cond) { stop("errormessage')} where appropriate across all packages.

@Aariq
Copy link
Collaborator Author

Aariq commented Aug 22, 2022

PEcAn.data.atmosphere::check_met_input_file() makes extensive use of testthat and will take some time to fix. However, it's not currently used by anything. Maybe this function doesn't need to get fixed in this PR.

@Aariq Aariq mentioned this pull request Aug 25, 2022
Closed
3 tasks
@Aariq Aariq marked this pull request as ready for review August 25, 2022 19:13
@Aariq Aariq changed the title WIP: replace testthat funs used in package code Replace testthat funs used in package code Aug 25, 2022
@dlebauer dlebauer merged commit f5194f8 into develop Aug 25, 2022
@dlebauer dlebauer deleted the remove-testthat-funs branch August 25, 2022 20:53
@Aariq Aariq mentioned this pull request Aug 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlebauer dlebauer dlebauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Aariq @dlebauer